Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1427653009: Revert of Roll ANGLE a5f64de..5b58cae (Closed)

Created:
5 years, 1 month ago by nasko
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll ANGLE a5f64de..5b58cae (patchset #1 id:1 of https://codereview.chromium.org/1407163009/ ) Reason for revert: This is breaking compilation on the bots: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/8034 FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/third_party/angle/src/tests/angle_unittests/DynamicHLSL_unittest.obj.rsp /c ../../third_party/angle/src/libANGLE/renderer/d3d/DynamicHLSL_unittest.cpp /Foobj/third_party/angle/src/tests/angle_unittests/DynamicHLSL_unittest.obj /Fdobj/third_party/angle/src/tests/angle_unittests_cc.pdb e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(43) :error C2146: syntax error : missing ';' before identifier 'DXGISwapChain' e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(43) :error C4430: missing type specifier - int assumed. Note: C++ does not support default-int e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(44) :error C2146: syntax error : missing ';' before identifier 'DXGIFactory' e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(44) :error C4430: missing type specifier - int assumed. Note: C++ does not support default-int e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\libangle\renderer\d3d\d3d11\nativewindow.h(60) :error C2061: syntax error : identifier 'ID3D11Device' ninja: build stopped: subcommand failed. Original issue's description: > Roll ANGLE a5f64de..5b58cae > > https://chromium.googlesource.com/angle/angle.git/+log/a5f64de..5b58cae > > BUG=504872, 509883, 541551 > > TEST=bots > > Committed: https://crrev.com/22c8fb80f8242c0eaf0c49bf23b5ffa96f6929a3 > Cr-Commit-Position: refs/heads/master@{#358149} TBR=jmadill@chromium.org,cwallez@chromium.org,cwallez@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504872, 509883, 541551 Committed: https://crrev.com/3128ec73085e55ec7b4704c9ae320e7d08a955ca Cr-Commit-Position: refs/heads/master@{#358180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nasko
Created Revert of Roll ANGLE a5f64de..5b58cae
5 years, 1 month ago (2015-11-05 23:43:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427653009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427653009/1
5 years, 1 month ago (2015-11-05 23:43:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-05 23:46:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3128ec73085e55ec7b4704c9ae320e7d08a955ca Cr-Commit-Position: refs/heads/master@{#358180}
5 years, 1 month ago (2015-11-05 23:47:08 UTC) #4
Corentin Wallez
5 years, 1 month ago (2015-11-06 15:07:43 UTC) #5
Message was sent while issue was closed.
On 2015/11/05 23:47:08, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/3128ec73085e55ec7b4704c9ae320e7d08a955ca
> Cr-Commit-Position: refs/heads/master@{#358180}

LGTM

Powered by Google App Engine
This is Rietveld 408576698