Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1427643009: dart2js cps: Fix bug in trampoline visitor. (Closed)

Created:
5 years, 1 month ago by asgerf
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Fix bug in trampoline visitor. If a continuation was visited directly (as the root of the trampoline) the actions pushed in traverseContinuation would not get processed. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/b466453025f68a805be69f15149c02c7adb4674c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
5 years, 1 month ago (2015-11-05 11:18:54 UTC) #3
Kevin Millikin (Google)
lgtm
5 years, 1 month ago (2015-11-05 11:54:05 UTC) #4
asgerf
5 years, 1 month ago (2015-11-05 12:15:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b466453025f68a805be69f15149c02c7adb4674c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698