Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/gflags/gflags.gyp

Issue 1427643003: pass clangcl compile options to ignore warnings in gflags.cc (Closed) Base URL: https://chromium.googlesource.com/libyuv/libyuv@master
Patch Set: bump version number Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/libyuv/version.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/gflags/gflags.gyp
diff --git a/third_party/gflags/gflags.gyp b/third_party/gflags/gflags.gyp
index 9c11e75a44a128121a04358351c8699834a36cfb..57567fa3ba0f6e52861639b79021fa9bb76a1691 100644
--- a/third_party/gflags/gflags.gyp
+++ b/third_party/gflags/gflags.gyp
@@ -63,6 +63,18 @@
}],
# TODO(andrew): Look into fixing this warning upstream:
# http://code.google.com/p/webrtc/issues/detail?id=760
+ ['OS=="win" and clang==1', {
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions!': [
+ '-Wheader-hygiene', # Suppress warning about using namespace.
+ ],
+ 'AdditionalOptions': [
+ '-Wno-unused-local-typedef', # Suppress unused private typedef.
+ ],
+ },
+ },
+ }],
['clang==1', {
'cflags!': ['-Wheader-hygiene',],
'xcode_settings': {
« no previous file with comments | « include/libyuv/version.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698