Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1427643003: pass clangcl compile options to ignore warnings in gflags.cc (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
ajm, ajm, fbarchard
CC:
kjellander_chromium
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : disabling warnings as errors is not necessary... removing that #

Patch Set 3 : check for clang and windows for doing clangcl options #

Patch Set 4 : bump version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M README.chromium View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/gflags/gflags.gyp View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
fbarchard1
5 years, 1 month ago (2015-10-27 23:36:12 UTC) #1
ajm
lgtm assuming it solves your problem.
5 years, 1 month ago (2015-10-28 02:00:33 UTC) #4
fbarchard
Added check for OS==win as well as clang before doing options specific to clang. Fixes ...
5 years, 1 month ago (2015-10-28 17:41:54 UTC) #6
fbarchard1
5 years, 1 month ago (2015-10-28 17:58:23 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
811a5ec446527992c71e727a4e7eed25bfa6c707 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698