content/browser/frame_host/navigator_impl.cc - Issue 1427633004: Send navigation_start to the browser in DidStartProvisionalLoad IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1427633004: Send navigation_start to the browser in DidStartProvisionalLoad IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation_start_renderer

Patch Set: Remove public method from NavigationHandle until consumers need it Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_handle_impl.h ('K') | « content/browser/frame_host/navigator_impl.h ('k') | content/browser/frame_host/render_frame_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index 788c23d356b18b45d4df4d95cec5b5bfa4f5ae1a..44bc5a8b9974266b3aa6a3b9dee813cdb8a177f1 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -119,7 +119,8 @@ NavigationController* NavigatorImpl::GetController() {

void NavigatorImpl::DidStartProvisionalLoad(

RenderFrameHostImpl* render_frame_host,

- const GURL& url) {

+ const GURL& url,

+ const base::TimeTicks& navigation_start) {

bool is_main_frame = render_frame_host->frame_tree_node()->IsMainFrame();

bool is_error_page = (url.spec() == kUnreachableWebDataURL);

bool is_iframe_srcdoc = (url.spec() == kAboutSrcDocURL);

@@ -160,7 +161,7 @@ void NavigatorImpl::DidStartProvisionalLoad(

}

render_frame_host->SetNavigationHandle(NavigationHandleImpl::Create(

- validated_url, render_frame_host->frame_tree_node()));

+ validated_url, render_frame_host->frame_tree_node(), navigation_start));

}

void NavigatorImpl::DidFailProvisionalLoadWithError(