Send navigation_start to the browser in DidStartProvisionalLoad IPC

content/browser/frame_host/navigation_handle_impl.h

Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index 6f46707108e531ceac132639638d387611e5710f..59db206000c15fcc9fe41ac3fd7a71c89c1daf6d 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -59,12 +59,14 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
  public:
   static scoped_ptr<NavigationHandleImpl> Create(
       const GURL& url,
-      FrameTreeNode* frame_tree_node);
+      FrameTreeNode* frame_tree_node,
+      const base::TimeTicks& navigation_start);
   ~NavigationHandleImpl() override;
 
   // NavigationHandle implementation:
   const GURL& GetURL() override;
   bool IsInMainFrame() override;
+  const base::TimeTicks& GetNavigationStart() override;
   bool IsPost() override;
   const Referrer& GetReferrer() override;
   bool HasUserGesture() override;
@@ -161,8 +163,14 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
     DID_COMMIT_ERROR_PAGE,
   };
 
+  // |navigation_start| comes from the DidStartProvisionalLoad IPC, which tracks
+  // both renderer-initiated and browser-initiated navigation start.
+  // PlzNavigate: Renderer-initated navigations send this with their

[clamy, 2015/11/04 13:53:39]

In PlzNavigate, it should always come from the CommonNavigationParams for
greater simplicity (and in the code it does !). Rephrase comment so that it is
simpler.

[Charlie Harrison, 2015/11/04 14:24:52]

Ahh you're right. Oops! Done.

+  // CommonNavigationParams. Browser-initiated navigations set it at the
+  // call-site.
   NavigationHandleImpl(const GURL& url,
-                       FrameTreeNode* frame_tree_node);
+                       FrameTreeNode* frame_tree_node,
+                       const base::TimeTicks& navigation_start);
 
   NavigationThrottle::ThrottleCheckResult CheckWillStartRequest();
   NavigationThrottle::ThrottleCheckResult CheckWillRedirectRequest();
@@ -197,6 +205,9 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
   // The index of the next throttle to check.
   size_t next_index_;
 
+  // The time this navigation started.
+  base::TimeTicks navigation_start_;

[clamy, 2015/11/04 13:53:39]

This should be const.

[Charlie Harrison, 2015/11/04 14:24:52]

Done.

+
   // This callback will be run when all throttle checks have been performed.
   ThrottleChecksFinishedCallback complete_callback_;