Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 1427633004: Send navigation_start to the browser in DidStartProvisionalLoad IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation_start_renderer
Patch Set: Comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "content/browser/frame_host/navigator_delegate.h" 10 #include "content/browser/frame_host/navigator_delegate.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 public: 46 public:
47 // Returns the delegate of this Navigator. 47 // Returns the delegate of this Navigator.
48 virtual NavigatorDelegate* GetDelegate(); 48 virtual NavigatorDelegate* GetDelegate();
49 49
50 // Returns the NavigationController associated with this Navigator. 50 // Returns the NavigationController associated with this Navigator.
51 virtual NavigationController* GetController(); 51 virtual NavigationController* GetController();
52 52
53 // Notifications coming from the RenderFrameHosts ---------------------------- 53 // Notifications coming from the RenderFrameHosts ----------------------------
54 54
55 // The RenderFrameHostImpl started a provisional load. 55 // The RenderFrameHostImpl started a provisional load.
56 virtual void DidStartProvisionalLoad(RenderFrameHostImpl* render_frame_host, 56 virtual void DidStartProvisionalLoad(
57 const GURL& url) {}; 57 RenderFrameHostImpl* render_frame_host,
58 const GURL& url,
59 const base::TimeTicks& navigation_start){};
nasko 2015/11/13 21:52:54 nit: There should be space between ) and {}. Is th
Charlie Harrison 2015/11/14 00:25:00 That's odd. clang-format actually prefers no space
nasko 2015/11/14 00:33:24 This might be some bug in clang-format. If it repr
58 60
59 // The RenderFrameHostImpl has failed a provisional load. 61 // The RenderFrameHostImpl has failed a provisional load.
60 virtual void DidFailProvisionalLoadWithError( 62 virtual void DidFailProvisionalLoadWithError(
61 RenderFrameHostImpl* render_frame_host, 63 RenderFrameHostImpl* render_frame_host,
62 const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {}; 64 const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {};
63 65
64 // The RenderFrameHostImpl has failed to load the document. 66 // The RenderFrameHostImpl has failed to load the document.
65 virtual void DidFailLoadWithError( 67 virtual void DidFailLoadWithError(
66 RenderFrameHostImpl* render_frame_host, 68 RenderFrameHostImpl* render_frame_host,
67 const GURL& url, 69 const GURL& url,
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 const base::TimeTicks& renderer_before_unload_end_time) {} 179 const base::TimeTicks& renderer_before_unload_end_time) {}
178 180
179 protected: 181 protected:
180 friend class base::RefCounted<Navigator>; 182 friend class base::RefCounted<Navigator>;
181 virtual ~Navigator() {} 183 virtual ~Navigator() {}
182 }; 184 };
183 185
184 } // namespace content 186 } // namespace content
185 187
186 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 188 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698