Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1724)

Issue 1427633003: Move scoped_test_dir.* and test_io_thread.* from edk/test to edk/system/test. (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move scoped_test_dir.* and test_io_thread.* from edk/test to edk/system/test. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d892e475b1b518f445944f019861f40225fe2c24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -247 lines) Patch
M mojo/edk/embedder/embedder_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/channel_test_base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/channel_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 11 chunks +11 lines, -14 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M mojo/edk/system/test/BUILD.gn View 2 chunks +8 lines, -1 line 0 comments Download
A + mojo/edk/system/test/scoped_test_dir.h View 2 chunks +5 lines, -3 lines 0 comments Download
A + mojo/edk/system/test/scoped_test_dir.cc View 2 chunks +3 lines, -1 line 0 comments Download
A + mojo/edk/system/test/test_io_thread.h View 3 chunks +5 lines, -3 lines 0 comments Download
A + mojo/edk/system/test/test_io_thread.cc View 3 chunks +3 lines, -1 line 0 comments Download
M mojo/edk/test/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/edk/test/scoped_test_dir.h View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/edk/test/scoped_test_dir.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/edk/test/test_io_thread.h View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/edk/test/test_io_thread.cc View 1 chunk +0 lines, -66 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 1 month ago (2015-10-29 00:09:29 UTC) #1
vardhan
lgtm
5 years, 1 month ago (2015-10-29 01:08:26 UTC) #2
viettrungluu
5 years, 1 month ago (2015-10-29 16:17:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d892e475b1b518f445944f019861f40225fe2c24 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698