Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1427593003: dart2js: Bugfix for when 'await' occurs in an initializer list. (Closed)

Created:
5 years, 1 month ago by asgerf
Modified:
5 years, 1 month ago
Reviewers:
karlklose, sigurdm
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Bugfix for when 'await' occurs in an initializer list. If the JS ast contains an initializer list: var x = foo(), y = await x; It would be retained as a single statement and generate invalid output that awaits 'x' before it has been defined. CLOSES=23997 BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/3634c3998a3efb85adfb1a388517a78b87aca208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -28 lines) Patch
M pkg/compiler/lib/src/js/rewrite_async.dart View 2 chunks +3 lines, -15 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/async_await_js_transform_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +0 lines, -4 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 1 month ago (2015-10-27 10:10:06 UTC) #2
sigurdm
LGTM Thanks!
5 years, 1 month ago (2015-10-27 10:32:26 UTC) #3
asgerf
5 years, 1 month ago (2015-10-27 10:37:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3634c3998a3efb85adfb1a388517a78b87aca208 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698