Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1427583008: [turbofan] Don't lookup private symbols on prototypes. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't lookup private symbols on prototypes. R=yangguo@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/18b37c7f59ae4bc47cf1529c47a3faff27f1e324 Cr-Commit-Position: refs/heads/master@{#31686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-30 11:53:21 UTC) #1
Yang
On 2015/10/30 11:53:21, Benedikt Meurer wrote: lgtm.
5 years, 1 month ago (2015-10-30 11:53:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427583008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427583008/1
5 years, 1 month ago (2015-10-30 11:54:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 12:14:38 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 12:14:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18b37c7f59ae4bc47cf1529c47a3faff27f1e324
Cr-Commit-Position: refs/heads/master@{#31686}

Powered by Google App Engine
This is Rietveld 408576698