src/utils/win/SkWGL_win.cpp - Issue 1427583007: Assert when running SampleApp with msaa 16 on Windows 10

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/win/SkWGL_win.cpp

Issue 1427583007: Assert when running SampleApp with msaa 16 on Windows 10 (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Review comments processing Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/win/SkWGL_win.cpp

diff --git a/src/utils/win/SkWGL_win.cpp b/src/utils/win/SkWGL_win.cpp

index ef07bea61e7bb2b6ac138c641d5d4febcd65799d..a26bce5eec11552ef50f43865bca64dfcbd7411c 100644

--- a/src/utils/win/SkWGL_win.cpp

+++ b/src/utils/win/SkWGL_win.cpp

@@ -123,6 +123,9 @@ int SkWGLExtensions::selectFormat(const int formats[],

int formatCount,

HDC dc,

int desiredSampleCount) const {

+ if (formatCount <= 0) {

+ return -1;

+ }

PixelFormat desiredFormat = {

desiredSampleCount,

« no previous file with comments | « no previous file | no next file » | no next file with comments »