Assert when running SampleApp with msaa 16 on Windows 10

Assert when running SampleApp with msaa 16 on Windows 10

Trivial: skip calling SkWGLExtensions::selectFormat with 0 elements,
 and handle if called.

BUG=4529
Committed: https://skia.googlesource.com/skia/+/2944fbb5329fc3026c541fa818489954d910625d

[aleksandar.stojiljkovic, 2015-10-30 09:08:12]

aleksandar.stojiljkovic@intel.com changed reviewers:
+ halcanary@chromium.org

[aleksandar.stojiljkovic, 2015-11-03 08:50:32]

aleksandar.stojiljkovic@intel.com changed reviewers:
+ reed@chromium.org

[hal.canary, 2015-11-03 18:16:47]

halcanary@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com
- halcanary@chromium.org

[hal.canary, 2015-11-03 18:17:14]

sending to reviews who know this file better than me.

[bsalomon, 2015-11-03 18:28:15]

https://codereview.chromium.org/1427583007/diff/1/src/utils/win/SkWGL_win.cpp
File src/utils/win/SkWGL_win.cpp (right):

https://codereview.chromium.org/1427583007/diff/1/src/utils/win/SkWGL_win.cpp...
src/utils/win/SkWGL_win.cpp:126: if (formatCount <= 0)
We always use braces

https://codereview.chromium.org/1427583007/diff/1/src/utils/win/SkWGL_win.cpp...
src/utils/win/SkWGL_win.cpp:321: formatsToTry[0] = num == 0 ? -1 :
extensions.selectFormat(formats, num, dc, msaaSampleCount);
We wrap lines at 100 (usually). Maybe rewrite with an if. Do we really need this
change with the above one?

[aleksandar.stojiljkovic, 2015-11-04 14:02:47]

Thanks, updated.

[bsalomon, 2015-11-04 14:10:17]

lgtm

[aleksandar.stojiljkovic, 2015-11-04 18:02:26]

On 2015/11/04 14:10:17, bsalomon wrote:
> lgtm

Don't have trybot and commit rights to repository; need to ask a committer to
submit it after review. Thanks.

[bsalomon, 2015-11-05 15:35:22]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-11-05 15:35:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1427583007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1427583007/20001

[commit-bot: I haz the power, 2015-11-05 15:48:15]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2944fbb5329fc3026c541fa818489954d910625d

[commit-bot: I haz the power, 2015-11-05 15:48:22]

Failed to apply the patch.

[aleksandar.stojiljkovic, 2015-11-05 19:23:06]

On 2015/11/05 15:48:22, commit-bot: I haz the power wrote:
> Failed to apply the patch.

Checking.