Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1427563002: Disclude Settings window and settings-frame from startup pages (Closed)

Created:
5 years, 1 month ago by stevenjb
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disclude Settings window and settings-frame from startup pages BUG=528069 Committed: https://crrev.com/7bd1741893bd4e233b5562a6926d7e395d558343 Cr-Commit-Position: refs/heads/master@{#356393}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use helper function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M chrome/browser/custom_home_pages_table_model.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 1 4 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
stevenjb
5 years, 1 month ago (2015-10-26 23:16:07 UTC) #2
sky
https://codereview.chromium.org/1427563002/diff/1/chrome/browser/custom_home_pages_table_model.cc File chrome/browser/custom_home_pages_table_model.cc (right): https://codereview.chromium.org/1427563002/diff/1/chrome/browser/custom_home_pages_table_model.cc#newcode191 chrome/browser/custom_home_pages_table_model.cc:191: if (browser->profile() != profile_) Can you move this and ...
5 years, 1 month ago (2015-10-27 13:07:46 UTC) #3
stevenjb
https://codereview.chromium.org/1427563002/diff/1/chrome/browser/custom_home_pages_table_model.cc File chrome/browser/custom_home_pages_table_model.cc (right): https://codereview.chromium.org/1427563002/diff/1/chrome/browser/custom_home_pages_table_model.cc#newcode191 chrome/browser/custom_home_pages_table_model.cc:191: if (browser->profile() != profile_) On 2015/10/27 13:07:46, sky wrote: ...
5 years, 1 month ago (2015-10-27 16:30:49 UTC) #4
stevenjb
https://codereview.chromium.org/1427563002/diff/1/chrome/browser/custom_home_pages_table_model.cc File chrome/browser/custom_home_pages_table_model.cc (right): https://codereview.chromium.org/1427563002/diff/1/chrome/browser/custom_home_pages_table_model.cc#newcode191 chrome/browser/custom_home_pages_table_model.cc:191: if (browser->profile() != profile_) On 2015/10/27 13:07:46, sky wrote: ...
5 years, 1 month ago (2015-10-27 16:30:50 UTC) #5
sky
LGTM
5 years, 1 month ago (2015-10-27 19:09:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427563002/20001
5 years, 1 month ago (2015-10-27 19:52:05 UTC) #8
sky
meta nit: change title from Disclude to Exclude.
5 years, 1 month ago (2015-10-27 20:22:47 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-27 21:04:08 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 21:05:04 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7bd1741893bd4e233b5562a6926d7e395d558343
Cr-Commit-Position: refs/heads/master@{#356393}

Powered by Google App Engine
This is Rietveld 408576698