Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: media/renderers/skcanvas_video_renderer.cc

Issue 1427543002: Modified old wait sync point functions to also accept new sync tokens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Folded sync_point into sync_tokens Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/renderers/skcanvas_video_renderer.cc
diff --git a/media/renderers/skcanvas_video_renderer.cc b/media/renderers/skcanvas_video_renderer.cc
index 7863a0d02e849dd37f966291df238755fdca696a..723aa2dba83ced9183f2232099ad3d5d6f4fb1a2 100644
--- a/media/renderers/skcanvas_video_renderer.cc
+++ b/media/renderers/skcanvas_video_renderer.cc
@@ -58,19 +58,19 @@ bool CheckColorSpace(const VideoFrame* video_frame, ColorSpace color_space) {
result == color_space;
}
-class SyncPointClientImpl : public VideoFrame::SyncPointClient {
+class SyncTokenClientImpl : public VideoFrame::SyncTokenClient {
public:
- explicit SyncPointClientImpl(gpu::gles2::GLES2Interface* gl) : gl_(gl) {}
- ~SyncPointClientImpl() override {}
+ explicit SyncTokenClientImpl(gpu::gles2::GLES2Interface* gl) : gl_(gl) {}
+ ~SyncTokenClientImpl() override {}
uint32 InsertSyncPoint() override { return gl_->InsertSyncPointCHROMIUM(); }
- void WaitSyncPoint(uint32 sync_point) override {
- gl_->WaitSyncPointCHROMIUM(sync_point);
+ void WaitSyncToken(const gpu::SyncToken& sync_token) override {
+ gl_->WaitSyncTokenCHROMIUM(sync_token.GetConstData());
}
private:
gpu::gles2::GLES2Interface* gl_;
- DISALLOW_IMPLICIT_CONSTRUCTORS(SyncPointClientImpl);
+ DISALLOW_IMPLICIT_CONSTRUCTORS(SyncTokenClientImpl);
};
skia::RefPtr<SkImage> NewSkImageFromVideoFrameYUVTextures(
@@ -95,7 +95,7 @@ skia::RefPtr<SkImage> NewSkImageFromVideoFrameYUVTextures(
DCHECK(mailbox_holder.texture_target == GL_TEXTURE_2D ||
mailbox_holder.texture_target == GL_TEXTURE_EXTERNAL_OES ||
mailbox_holder.texture_target == GL_TEXTURE_RECTANGLE_ARB);
- gl->WaitSyncPointCHROMIUM(mailbox_holder.sync_point);
+ gl->WaitSyncTokenCHROMIUM(mailbox_holder.sync_token.GetConstData());
source_textures[i] = gl->CreateAndConsumeTextureCHROMIUM(
mailbox_holder.texture_target, mailbox_holder.mailbox.name);
@@ -164,7 +164,7 @@ skia::RefPtr<SkImage> NewSkImageFromVideoFrameNative(
gl, video_frame, source_texture, GL_RGBA, GL_UNSIGNED_BYTE, true,
false);
} else {
- gl->WaitSyncPointCHROMIUM(mailbox_holder.sync_point);
+ gl->WaitSyncTokenCHROMIUM(mailbox_holder.sync_token.GetConstData());
source_texture = gl->CreateAndConsumeTextureCHROMIUM(
mailbox_holder.texture_target, mailbox_holder.mailbox.name);
}
@@ -415,8 +415,8 @@ void SkCanvasVideoRenderer::Paint(const scoped_refptr<VideoFrame>& video_frame,
if (video_frame->HasTextures()) {
DCHECK(gl);
- SyncPointClientImpl client(gl);
- video_frame->UpdateReleaseSyncPoint(&client);
+ SyncTokenClientImpl client(gl);
+ video_frame->UpdateReleaseSyncToken(&client);
}
}
@@ -551,7 +551,7 @@ void SkCanvasVideoRenderer::CopyVideoFrameSingleTextureToGLTexture(
mailbox_holder.texture_target == GL_TEXTURE_EXTERNAL_OES)
<< mailbox_holder.texture_target;
- gl->WaitSyncPointCHROMIUM(mailbox_holder.sync_point);
+ gl->WaitSyncTokenCHROMIUM(mailbox_holder.sync_token.GetConstData());
uint32 source_texture = gl->CreateAndConsumeTextureCHROMIUM(
mailbox_holder.texture_target, mailbox_holder.mailbox.name);
@@ -568,8 +568,8 @@ void SkCanvasVideoRenderer::CopyVideoFrameSingleTextureToGLTexture(
gl->DeleteTextures(1, &source_texture);
gl->Flush();
- SyncPointClientImpl client(gl);
- video_frame->UpdateReleaseSyncPoint(&client);
+ SyncTokenClientImpl client(gl);
+ video_frame->UpdateReleaseSyncToken(&client);
}
void SkCanvasVideoRenderer::ResetCache() {

Powered by Google App Engine
This is Rietveld 408576698