Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: content/browser/renderer_host/media/video_capture_device_client.cc

Issue 1427543002: Modified old wait sync point functions to also accept new sync tokens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Folded sync_point into sync_tokens Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/video_capture_device_client.cc
diff --git a/content/browser/renderer_host/media/video_capture_device_client.cc b/content/browser/renderer_host/media/video_capture_device_client.cc
index de127994ee8b82053ff9dc905d90b30d0ab9f5c4..e92381a8589f8e4fc0fef71deb9a46b431e89098 100644
--- a/content/browser/renderer_host/media/video_capture_device_client.cc
+++ b/content/browser/renderer_host/media/video_capture_device_client.cc
@@ -138,7 +138,7 @@ class AutoReleaseBuffer : public media::VideoCaptureDevice::Client::Buffer {
// Internal ref-counted class wrapping an incoming GpuMemoryBuffer into a
// Texture backed VideoFrame. This VideoFrame creation is balanced by a waiting
-// on the associated |sync_point|. After VideoFrame consumption the inserted
+// on the associated |sync_token|. After VideoFrame consumption the inserted
// ReleaseCallback() will be called, where the Texture is destroyed.
//
// This class jumps between threads due to GPU-related thread limitations, i.e.
@@ -172,7 +172,7 @@ class VideoCaptureDeviceClient::TextureWrapHelper final
// Recycles |memory_buffer|, deletes Image and Texture on VideoFrame release.
void ReleaseCallback(const std::vector<GLuint>& image_ids,
const std::vector<GLuint>& texture_ids,
- uint32 sync_point);
+ const gpu::SyncToken& sync_token);
// The Command Buffer lost the GL context, f.i. GPU process crashed. Signal
// error to our owner so the capture can be torn down.
@@ -648,7 +648,7 @@ VideoCaptureDeviceClient::TextureWrapHelper::OnIncomingCapturedGpuMemoryBuffer(
DCHECK(!mailbox_holder.mailbox.IsZero());
DCHECK(mailbox_holder.mailbox.Verify());
DCHECK(mailbox_holder.texture_target);
- DCHECK(mailbox_holder.sync_point);
+ DCHECK(mailbox_holder.sync_token.HasData());
mailbox_holders.push_back(mailbox_holder);
}
@@ -739,7 +739,7 @@ void VideoCaptureDeviceClient::TextureWrapHelper::CreateGlHelper(
void VideoCaptureDeviceClient::TextureWrapHelper::ReleaseCallback(
const std::vector<GLuint>& image_ids,
const std::vector<GLuint>& texture_ids,
- uint32 sync_point) {
+ const gpu::SyncToken& sync_token) {
DCHECK(capture_task_runner_->BelongsToCurrentThread());
DCHECK_EQ(image_ids.size(), texture_ids.size());

Powered by Google App Engine
This is Rietveld 408576698