third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp - Issue 1427543002: Modified old wait sync point functions to also accept new sync tokens.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp

Issue 1427543002: Modified old wait sync point functions to also accept new sync tokens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp ('k') | third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp b/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp

index 51465ee01b9e4dae52de954ec294657ae3c1f78c..06088dc9d96fd00d3197d204eef963a114bd624c 100644

--- a/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp

+++ b/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp

@@ -214,9 +214,10 @@ bool ImageBuffer::copyToPlatformTexture(WebGraphicsContext3D* context, Platform3

sharedContext->produceTextureDirectCHROMIUM(textureId, GL_TEXTURE_2D, mailbox->name);

sharedContext->flush();

- mailbox->syncPoint = sharedContext->insertSyncPoint();

+ mailbox->validSyncToken = sharedContext->insertSyncPoint(mailbox->syncToken);

+ if (mailbox->validSyncToken)

+ context->waitSyncToken(mailbox->syncToken);

- context->waitSyncPoint(mailbox->syncPoint);

Platform3DObject sourceTexture = context->createAndConsumeTextureCHROMIUM(GL_TEXTURE_2D, mailbox->name);

// The canvas is stored in a premultiplied format, so unpremultiply if necessary.

@@ -226,7 +227,10 @@ bool ImageBuffer::copyToPlatformTexture(WebGraphicsContext3D* context, Platform3

context->deleteTexture(sourceTexture);

context->flush();

- sharedContext->waitSyncPoint(context->insertSyncPoint());

+ WGC3Dbyte syncToken[24];

+ if (context->insertSyncPoint(syncToken))

+ sharedContext->waitSyncToken(syncToken);

// Undo grContext texture binding changes introduced in this function

provider->grContext()->resetContext(kTextureBinding_GrGLBackendState);