Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1427513003: Compute documentation offsets for library, import, and export directive elements (issue 24756) (Closed)

Created:
5 years, 1 month ago by Brian Wilkerson
Modified:
5 years, 1 month ago
Reviewers:
keertip
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute documentation offsets for library, import, and export directive elements (issue 24756) R=keertip@google.com Committed: https://github.com/dart-lang/sdk/commit/677d4b5bbc97c2aee1b03de8398ffedf977cd703

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -14 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 8 chunks +33 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 5 chunks +49 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 1 month ago (2015-10-29 20:51:25 UTC) #2
keertip
lgtm
5 years, 1 month ago (2015-10-29 20:56:13 UTC) #3
Brian Wilkerson
5 years, 1 month ago (2015-10-29 21:00:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
677d4b5bbc97c2aee1b03de8398ffedf977cd703 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698