Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1427463003: Teach `mojo_benchmark` to upload results to perf dashboard. (Closed)

Created:
5 years, 1 month ago by ppi
Modified:
5 years, 1 month ago
Reviewers:
etiennej, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Teach `mojo_benchmark` to upload results to perf dashboard. This patch makes `mojo_benchmark` upload results to performance dashboard if `--upload` is passed. Actually turning this on the perf bot will come in a separate cl. See #474. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6ead3a97f246e1120fbd533ab1b8faea2c44fd2c

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -13 lines) Patch
M mojo/devtools/common/devtoolslib/perf_dashboard.py View 1 1 chunk +13 lines, -0 lines 0 comments Download
M mojo/devtools/common/docs/mojo_benchmark.md View 1 1 chunk +28 lines, -0 lines 0 comments Download
M mojo/devtools/common/mojo_benchmark View 1 5 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Ben or Etienne, ptal.
5 years, 1 month ago (2015-10-27 16:42:30 UTC) #2
qsr
lgtm
5 years, 1 month ago (2015-10-28 08:35:52 UTC) #3
ppi
5 years, 1 month ago (2015-10-28 09:14:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6ead3a97f246e1120fbd533ab1b8faea2c44fd2c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698