Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1427443002: Add optional data parameter to SetAccessCheckCallback (Closed)

Created:
5 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add optional data parameter to SetAccessCheckCallback The data field is passed to the failed access check callback which blink depends on. BUG=none R=verwaest@chromium.org LOG=n Committed: https://crrev.com/e2675937d5b6d2e555edeaabcda7ce70551ea236 Cr-Commit-Position: refs/heads/master@{#31555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M include/v8.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/api.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 1 month ago (2015-10-26 09:43:31 UTC) #1
Toon Verwaest
lgtm
5 years, 1 month ago (2015-10-26 09:56:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427443002/1
5 years, 1 month ago (2015-10-26 09:59:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 10:42:14 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 10:42:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2675937d5b6d2e555edeaabcda7ce70551ea236
Cr-Commit-Position: refs/heads/master@{#31555}

Powered by Google App Engine
This is Rietveld 408576698