Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1427433016: Add kundaji and tbansal to data reduction proxy OWNERS. (Closed)

Created:
5 years, 1 month ago by Not at Google. Contact bengr
Modified:
5 years, 1 month ago
Reviewers:
bengr, Cait (Slow)
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add kundaji and tbansal to data reduction proxy OWNERS. Committed: https://crrev.com/42117bb2912be0463d68b5767e8b1207c95fccae Cr-Commit-Position: refs/heads/master@{#359195}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Alphabetize #

Patch Set 3 : Alphabetize resources file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M chrome/browser/net/spdyproxy/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/OWNERS View 1 1 chunk +4 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/resources/OWNERS View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M components/test/data/data_reduction_proxy/OWNERS View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Not at Google. Contact bengr
bengr: chrome/browser/net/spdyproxy/OWNERS components/data_reduction_proxy/OWNERS sdefresne: components/OWNERS components/resources/OWNERS
5 years, 1 month ago (2015-11-10 17:37:40 UTC) #2
bengr
lgtm modulo alphabetization. https://codereview.chromium.org/1427433016/diff/1/chrome/browser/net/spdyproxy/OWNERS File chrome/browser/net/spdyproxy/OWNERS (right): https://codereview.chromium.org/1427433016/diff/1/chrome/browser/net/spdyproxy/OWNERS#newcode4 chrome/browser/net/spdyproxy/OWNERS:4: kundaji@chromium.org Please alphabetize. https://codereview.chromium.org/1427433016/diff/1/components/OWNERS File components/OWNERS ...
5 years, 1 month ago (2015-11-10 18:15:35 UTC) #3
Not at Google. Contact bengr
https://codereview.chromium.org/1427433016/diff/1/chrome/browser/net/spdyproxy/OWNERS File chrome/browser/net/spdyproxy/OWNERS (right): https://codereview.chromium.org/1427433016/diff/1/chrome/browser/net/spdyproxy/OWNERS#newcode4 chrome/browser/net/spdyproxy/OWNERS:4: kundaji@chromium.org On 2015/11/10 18:15:35, bengr wrote: > Please alphabetize. ...
5 years, 1 month ago (2015-11-10 18:36:39 UTC) #4
Not at Google. Contact bengr
bengr: chrome/browser/net/spdyproxy/OWNERS components/data_reduction_proxy/OWNERS caitkp: components/OWNERS components/resources/OWNERS
5 years, 1 month ago (2015-11-11 17:34:02 UTC) #6
Cait (Slow)
lgtm
5 years, 1 month ago (2015-11-11 21:24:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427433016/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427433016/40001
5 years, 1 month ago (2015-11-11 21:28:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/77478)
5 years, 1 month ago (2015-11-11 21:39:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427433016/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427433016/40001
5 years, 1 month ago (2015-11-11 22:13:21 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-12 00:48:05 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:02:09 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/42117bb2912be0463d68b5767e8b1207c95fccae
Cr-Commit-Position: refs/heads/master@{#359195}

Powered by Google App Engine
This is Rietveld 408576698