Simple LRU class

media/blink/test_random.h

+// Copyright 2013 The Chromium Authors. All rights reserved.

[xhwang, 2015/11/10 00:50:01]

2015

[hubbe, 2015/11/10 18:26:15]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_BLINK_TEST_RANDOM_H_
+#define MEDIA_BLINK_TEST_RANDOM_H_
+
+// Vastly simplified ACM random class meant to only be used for testing.

[xhwang, 2015/11/10 00:50:01]

Could you please provide more context here why methods in base/rand_util.h
aren't sufficient and we have to develop our own here. In that case, does it
make sense to add this to base/rand_util.h?

Also, it'd be nice to provide a reference to the ACM random class.

[hubbe, 2015/11/10 18:26:15]

Done.

+
+namespace media {
+
+class TestRandom {
+ public:
+  explicit TestRandom(uint32 seed) {

[xhwang, 2015/11/10 00:50:01]

nit: for new files use uint32_t as per style guide.

[hubbe, 2015/11/10 18:26:15]

Done.

+    seed_ = seed & 0x7fffffff;  // make this a non-negative number
+    if (seed_ == 0 || seed_ == M) {
+      seed_ = 1;
+    }
+  }
+
+  int32 Rand() {
+    static const uint64 A = 16807;  // bits 14, 8, 7, 5, 2, 1, 0
+    seed_ = static_cast<int32>((seed_ * A) % M);
+    CHECK_GT(seed_, 0);
+    return seed_;
+  }
+
+ private:
+  static const uint64 M = 2147483647L;  // 2^32-1
+  int32 seed_;
+};
+
+}  // namespace media
+
+#endif  // MEDIA_BLINK_TEST_RANDOM_H_