chrome/common/extensions/docs/templates/private/sidenav_item.html - Issue 14273041: Doc server manifest page generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/templates/private/sidenav_item.html

Issue 14273041: Doc server manifest page generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Codereview and polish Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/templates/json/extensions_sidenav.json ('K') | « chrome/common/extensions/docs/templates/private/sidenav.html ('k') | chrome/common/extensions/docs/templates/private/sidenav_items.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/templates/private/sidenav_item.html

diff --git a/chrome/common/extensions/docs/templates/private/sidenav_item.html b/chrome/common/extensions/docs/templates/private/sidenav_item.html

index ad7c6ccb149362304453074ed4e0fc74fa5a30c8..60b674b756d59cdb039443c847480854e934afef 100644

--- a/chrome/common/extensions/docs/templates/private/sidenav_item.html

+++ b/chrome/common/extensions/docs/templates/private/sidenav_item.html

@@ -6,12 +6,12 @@

</a>

- <a {{^item.selected}}href="{{item.fileName}}"{{/}} class="level{{item.level}} {{?item.selected}}selected{{/}}">{{item.title}}</a>

+ <a {{^item.selected}}href="{{^absolute_url}}{{base_url}}{{/}}{{item.fileName}}"{{/}} class="level{{item.level}} {{?item.selected}}selected{{/}}">{{item.title}}</a>

<span class="level{{item.level}}">{{item.title}}</span>

- {{+partials.sidenav_items items:item.items parent:item}}

+ {{+partials.sidenav_items items:item.items parent:item base_url:base_url}}

</li>