Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6121)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/docs/server2/sidenav_data_source.py

Issue 14273041: Doc server manifest page generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Codereview and polish Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/extensions/docs/server2/server_instance.py ('K') | « chrome/common/extensions/docs/server2/server_instance.py ('k') | chrome/common/extensions/docs/server2/subversion_file_system.py » ('j') | chrome/common/extensions/docs/server2/template_data_source.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/server2/sidenav_data_source.py
diff --git a/chrome/common/extensions/docs/server2/sidenav_data_source.py b/chrome/common/extensions/docs/server2/sidenav_data_source.py
index f340eb891159f106bc2abbda6649b6dc7952f23c..60e40fab09f94b19ed8cad89a67f3715bd1c1906 100644
--- a/chrome/common/extensions/docs/server2/sidenav_data_source.py
+++ b/chrome/common/extensions/docs/server2/sidenav_data_source.py
@@ -4,10 +4,6 @@
import copy
import json
-import logging
-
-import compiled_file_system as compiled_fs
-from third_party.json_schema_compiler.model import UnixName
class SidenavDataSource(object):
"""This class reads in and caches a JSON file representing the side navigation
@@ -57,7 +53,7 @@ class SidenavDataSource(object):
return False
def get(self, key):
- sidenav = copy.deepcopy(self._cache.GetFromFile(
+ sidenav_items = copy.deepcopy(self._cache.GetFromFile(
'%s/%s_sidenav.json' % (self._json_path, key)))
- self._AddSelected(sidenav)
- return sidenav
+ self._AddSelected(sidenav_items)
+ return sidenav_items
« chrome/common/extensions/docs/server2/server_instance.py ('K') | « chrome/common/extensions/docs/server2/server_instance.py ('k') | chrome/common/extensions/docs/server2/subversion_file_system.py » ('j') | chrome/common/extensions/docs/server2/template_data_source.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698