Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5429)

Unified Diff: chrome/common/extensions/docs/server2/template_data_source.py

Issue 14273041: Doc server manifest page generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix imports Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/template_data_source.py
diff --git a/chrome/common/extensions/docs/server2/template_data_source.py b/chrome/common/extensions/docs/server2/template_data_source.py
index ca065d331b5ea46005500c66d71fd90149c3f43c..7ad4daea48a7260286298694e5efafb5e3ef2435 100644
--- a/chrome/common/extensions/docs/server2/template_data_source.py
+++ b/chrome/common/extensions/docs/server2/template_data_source.py
@@ -45,6 +45,7 @@ class TemplateDataSource(object):
sidenav_data_source_factory,
compiled_fs_factory,
ref_resolver_factory,
+ manifest_data_source,
public_template_path,
private_template_path,
base_path):
@@ -58,6 +59,7 @@ class TemplateDataSource(object):
self._ref_resolver = ref_resolver_factory.Create()
self._public_template_path = public_template_path
self._private_template_path = private_template_path
+ self._manifest_data_source = manifest_data_source
self._base_path = base_path
def _CreateTemplate(self, template_name, text):
@@ -73,6 +75,7 @@ class TemplateDataSource(object):
self._samples_data_source_factory.Create(request),
self._sidenav_data_source_factory.Create(path),
self._cache,
+ self._manifest_data_source,
self._public_template_path,
self._private_template_path,
self._base_path)
@@ -84,6 +87,7 @@ class TemplateDataSource(object):
samples_data_source,
sidenav_data_source,
cache,
+ manifest_data_source,
public_template_path,
private_template_path,
base_path):
@@ -95,6 +99,7 @@ class TemplateDataSource(object):
self._cache = cache
self._public_template_path = public_template_path
self._private_template_path = private_template_path
+ self._manifest_data_source = manifest_data_source
self._base_path = base_path
def Render(self, template_name):
@@ -112,6 +117,7 @@ class TemplateDataSource(object):
'intros': self._intro_data_source,
'sidenavs': self._sidenav_data_source,
'partials': self,
+ 'manifest_source': self._manifest_data_source,
'samples': self._samples_data_source,
'apps_samples_url': url_constants.GITHUB_BASE,
'extensions_samples_url': url_constants.EXTENSIONS_SAMPLES,
@@ -132,5 +138,5 @@ class TemplateDataSource(object):
try:
return self._cache.GetFromFile(
'/'.join((base_path, FormatKey(template_name))))
- except FileNotFoundError as e:
+ except FileNotFoundError:
return None

Powered by Google App Engine
This is Rietveld 408576698