On 2013/04/27 01:54:02, kalman wrote:
> it'd be nice to also put these in a subdirectory but we'd need to make sure
that
> the links are safe (e.g. have appropriate ../.. in them).
Just to clarify, I should make it such that the URL
server/extensions/manifest/name.html renders the template in
/public/extensions/manifest/name.html?
not at google - send to devlin
2013/05/03 15:56:24
Yep. Transform manifest_foo.html into manifest/foo
On 2013/05/03 03:44:39, jaredshumway94 wrote:
> On 2013/04/27 01:54:02, kalman wrote:
> > it'd be nice to also put these in a subdirectory but we'd need to make sure
> that
> > the links are safe (e.g. have appropriate ../.. in them).
>
> Just to clarify, I should make it such that the URL
> server/extensions/manifest/name.html renders the template in
> /public/extensions/manifest/name.html?
Yep. Transform manifest_foo.html into manifest/foo.html for all applicable. I
think you'll need to modify the sidebar code to give absolute paths (don't
forget to include the branch)
jshumway
2013/05/10 02:08:36
I got absolute paths working for apps/extensions,
On 2013/05/03 15:56:24, kalman wrote:
> On 2013/05/03 03:44:39, jaredshumway94 wrote:
> > On 2013/04/27 01:54:02, kalman wrote:
> > > it'd be nice to also put these in a subdirectory but we'd need to make
sure
> > that
> > > the links are safe (e.g. have appropriate ../.. in them).
> >
> > Just to clarify, I should make it such that the URL
> > server/extensions/manifest/name.html renders the template in
> > /public/extensions/manifest/name.html?
>
> Yep. Transform manifest_foo.html into manifest/foo.html for all applicable. I
> think you'll need to modify the sidebar code to give absolute paths (don't
> forget to include the branch
I got absolute paths working for apps/extensions, but everything appears to be
/trunk with preview.py. I also changed the sample's link to be absolute.
Issue 14273041: Doc server manifest page generation
(Closed)
Created 7 years, 8 months ago by jshumway
Modified 7 years, 5 months ago
Reviewers: cduvall, not at google - send to devlin, mkearney1
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 131