Doc server manifest page generation

chrome/common/extensions/docs/server2/manifest_data_source.py

+# Copyright (c) 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from copy import deepcopy
+import json
+import os
+
+from svn_constants import JSON_PATH

[not at google - send to devlin, 2013/05/03 15:56:25]

this is the kind of thing to pass into the constructor of ManifestDataSource to
make it easier to test.

[jshumway, 2013/05/10 02:08:36]

Done.

+
+def apply_apps_transformations(manifest):

[not at google - send to devlin, 2013/05/03 15:56:25]

should be _ApplyAppsTransformations

[jshumway, 2013/05/10 02:08:36]

Done.

+  manifest['required'][0]['example'] = 'My Application'
+
+def apply_extensions_transformations(manifest):
+  pass

[not at google - send to devlin, 2013/05/03 15:56:25]

almost there - but this needs to filter the manifest items according to whether
they're available to extensions vs apps, and for that these methods needs access
to the manifest feature file.

[jshumway, 2013/05/10 02:08:36]

This was one of the major of my patch. Now the manifest.json file is checked and
paired with entries in _manifest_features. Features is consulted to check what
entries should be show on which branches. After the entries in manifest.json are
exhausted, the remaining entries in features are added to the bottom of the
manifest example as plain text (not links) with an example of '...'. 

+
+class ManifestDataSource(object):
+  """ Provides a template with access to manifest properties specific to apps or
+  extensions.
+  """
+  def __init__(self, compiled_fs_factory, store_type):
+    self._compiled_fs = compiled_fs_factory.Create(
+      lambda _, contents: json.loads(contents), store_type)

[not at google - send to devlin, 2013/05/03 15:56:25]

the store_type variable is so that each class can guarantee its own area. don't
pass it in, it should be ManifestDataSource.

[jshumway, 2013/05/10 02:08:36]

Done.

+
+    self.loaded = False
+
+  def get(self, key):
+    if not self.loaded:

[not at google - send to devlin, 2013/05/03 15:56:25]

CompiledFileSystem implements this loading logic itself (and combines it with
various caching to share it across instances).

I would expect to see instead of

lambda _, contents: json.loads(contents), store_type

above, instead a reference to a function which does everything in get() up to
actually returning the key.

self._compiled_fs = compiled_fs_factory.Create(
  _CreateManifestData, ManifestDataSource)

def _CreateManifestData(self_, contents):
  ...
  return {'apps': ..., 'extensions': ...}

def get(self):
  return self._compiled_fs.GetFromFile(...)[key]

then the KeyError happens automatically, too.

[jshumway, 2013/05/10 02:08:36]

Done.

+      manifest_json = self._compiled_fs.GetFromFile(
+        os.path.join(JSON_PATH, 'manifest.json'))
+      self.extensions = deepcopy(manifest_json)
+      self.apps = deepcopy(manifest_json)
+
+      apply_apps_transformations(self.apps)
+      apply_extensions_transformations(self.extensions)
+      self.loaded = True
+
+    if key == 'apps':
+      return self.apps
+    elif key == 'extensions':
+      return self.extensions
+    else:
+      raise KeyError