Issue 14273040: On Windows 8 don't assume that the browser is shutting down in desktop mode because the ASH environ…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14273040: On Windows 8 don't assume that the browser is shutting down in desktop mode because the ASH environ… (Closed)

Created:
7 years, 8 months ago by ananta

Modified:
7 years, 7 months ago

Reviewers:
Ben, cpu_(ooo_6.6-7.5)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

On Windows 8 don't assume that the browser is shutting down in desktop mode because the ASH environment could be still active. We currently have a check for this in the ShouldStartShutdown function in the application_lifetime.cc file which is called when a browser window is being closed. It checks for whether both browser lists (desktop and ASH) are empty. However ASH could be active without any active browser windows. Updated the checks to account for this. BUG=235654 R=cpu TBR=ben Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197142

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
	M	chrome/browser/lifetime/application_lifetime.cc	View	1	2 chunks	+12 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ananta

7 years, 7 months ago (2013-04-29 21:11:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r197142 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14273040: On Windows 8 don't assume that the browser is shutting down in desktop mode because the ASH environ… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages