cc: Make async readback path use async glRreadPixels.

cc/test/pixel_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/pixel_test.h"
 
+#include "base/message_loop.h"
 #include "base/path_service.h"
 #include "cc/output/compositor_frame_metadata.h"
 #include "cc/output/gl_renderer.h"
 #include "cc/output/output_surface.h"
 #include "cc/resources/resource_provider.h"
 #include "cc/test/paths.h"
 #include "cc/test/pixel_test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gl/gl_implementation.h"
 #include "webkit/gpu/context_provider_in_process.h"
@@ skipping 62 matching lines @@
 
 bool PixelTest::RunPixelTest(RenderPassList* pass_list,
                              const base::FilePath& ref_file,
                              const PixelComparator& comparator) {
   pass_list->back()->copy_callbacks.push_back(
       base::Bind(&PixelTest::ReadbackResult, base::Unretained(this)));
 
   renderer_->DecideRenderPassAllocationsForFrame(*pass_list);
   renderer_->DrawFrame(pass_list);
 
-  // TODO(danakj): When the glReadPixels is async, wait for it to finish.
+  // Wait for the readback to complete.
+  output_surface_->context3d()->finish();
+  base::MessageLoop::current()->Run();

[piman, 2013/04/27 00:42:25]

Any way we can use base::RunLoop instead (generally safer)?

[danakj, 2013/04/29 14:59:05]

I will introduce myself to RunLoop. (Oh, it is neet.)

 
   return PixelsMatchReference(ref_file, comparator);
 }
 
 void PixelTest::ReadbackResult(scoped_ptr<SkBitmap> bitmap) {
   result_bitmap_ = bitmap.Pass();
+  base::MessageLoop::current()->QuitWhenIdle();
 }
 
 bool PixelTest::PixelsMatchReference(const base::FilePath& ref_file,
                                      const PixelComparator& comparator) {
   base::FilePath test_data_dir;
   if (!PathService::Get(cc::DIR_TEST_DATA, &test_data_dir))
     return false;
 
   // If this is false, we didn't set up a readback on a render pass.
   if (!result_bitmap_)
     return false;
 
   // To rebaseline:
   // return WritePNGFile(*result_bitmap_, test_data_dir.Append(ref_file), true);
 
   return MatchesPNGFile(*result_bitmap_,
                         test_data_dir.Append(ref_file),
                         comparator);
 }
 
 }  // namespace cc