Report OOM errors instead of asserting on allocation failures when sending

runtime/vm/snapshot.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/snapshot.h"
 
 #include "platform/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
 #include "vm/class_finalizer.h"
@@ skipping 842 matching lines @@
 SnapshotWriter::SnapshotWriter(Snapshot::Kind kind,
                                uint8_t** buffer,
                                ReAlloc alloc,
                                intptr_t initial_size)
     : BaseWriter(buffer, alloc, initial_size),
       kind_(kind),
       object_store_(Isolate::Current()->object_store()),
       class_table_(Isolate::Current()->class_table()),
       forward_list_(),
       exception_type_(Exceptions::kNone),
-      exception_msg_(NULL),
-      error_(LanguageError::Handle()) {
+      exception_msg_(NULL) {
 }
 
 
 void SnapshotWriter::WriteObject(RawObject* rawobj) {
   WriteObjectImpl(rawobj);
   WriteForwardedObjects();
 }
 
 
 void SnapshotWriter::HandleVMIsolateObject(RawObject* rawobj) {
@@ skipping 154 matching lines @@
   ASSERT(isolate != NULL);
   ObjectStore* object_store = isolate->object_store();
   ASSERT(object_store != NULL);
   ASSERT(ClassFinalizer::AllClassesFinalized());
 
   // Setup for long jump in case there is an exception while writing
   // the snapshot.
   LongJump* base = isolate->long_jump_base();
   LongJump jump;
   isolate->set_long_jump_base(&jump);
-  // TODO(6726): Allocate these constant strings once in the VM isolate.
-  *ErrorHandle() = LanguageError::New(
-      String::Handle(String::New("Error while writing full snapshot")));
   if (setjmp(*jump.Set()) == 0) {
     NoGCScope no_gc;
 
     // Reserve space in the output buffer for a snapshot header.
     ReserveHeader();
 
     // Write out all the objects in the object store of the isolate which
     // is the root set for all dart allocated objects at this point.
     SnapshotWriterVisitor visitor(this, false);
     object_store->VisitObjectPointers(&visitor);
@@ skipping 275 matching lines @@
     SetWriteException(Exceptions::kArgument,
                       "Illegal argument in isolate message"
                       " : (object extends NativeWrapper)");
   }
 }
 
 
 void SnapshotWriter::SetWriteException(Exceptions::ExceptionType type,
                                        const char* msg) {
   set_exception_type(type);
-  // TODO(6726): Allocate these constant strings once in the VM isolate.
   set_exception_msg(msg);
-  Isolate::Current()->long_jump_base()->Jump(1, *ErrorHandle());
+  // The more specific error is set up in SnapshotWriter::ThrowException().
+  Isolate::Current()->long_jump_base()->
+      Jump(1, Object::snapshot_writer_error());
 }
 
 
 void SnapshotWriter::WriteInstance(intptr_t object_id,
                                    RawObject* raw,
                                    RawClass* cls,
                                    intptr_t tags) {
   // First check if object is a closure or has native fields.
   CheckIfSerializable(cls);
 
@@ skipping 43 matching lines @@
 
   // Write out the class information for this object.
   WriteObjectImpl(cls);
 }
 
 
 void SnapshotWriter::ThrowException(Exceptions::ExceptionType type,
                                     const char* msg) {
   Isolate::Current()->object_store()->clear_sticky_error();
   UnmarkAll();
-  const String& msg_obj = String::Handle(String::New(msg));
-  const Array& args = Array::Handle(Array::New(1));
-  args.SetAt(0, msg_obj);
-  Exceptions::ThrowByType(type, args);
+  if (msg != NULL) {
+    const String& msg_obj = String::Handle(String::New(msg));
+    const Array& args = Array::Handle(Array::New(1));
+    args.SetAt(0, msg_obj);
+    Exceptions::ThrowByType(type, args);
+  } else {
+    Exceptions::ThrowByType(type, Object::empty_array());
+  }
   UNREACHABLE();
 }
 
 
 void ScriptSnapshotWriter::WriteScriptSnapshot(const Library& lib) {
   ASSERT(kind() == Snapshot::kScript);
   Isolate* isolate = Isolate::Current();
   ASSERT(isolate != NULL);
   ASSERT(ClassFinalizer::AllClassesFinalized());
 
   // Setup for long jump in case there is an exception while writing
   // the snapshot.
   LongJump* base = isolate->long_jump_base();
   LongJump jump;
   isolate->set_long_jump_base(&jump);
-  *ErrorHandle() = LanguageError::New(
-      String::Handle(String::New("Error while writing script snapshot")));
   if (setjmp(*jump.Set()) == 0) {
     // Write out the library object.
     NoGCScope no_gc;
     ReserveHeader();
     WriteObject(lib.raw());
     FillHeader(kind());
     UnmarkAll();
     isolate->set_long_jump_base(base);
   } else {
     isolate->set_long_jump_base(base);
@@ skipping 17 matching lines @@
 void MessageWriter::WriteMessage(const Object& obj) {
   ASSERT(kind() == Snapshot::kMessage);
   Isolate* isolate = Isolate::Current();
   ASSERT(isolate != NULL);
 
   // Setup for long jump in case there is an exception while writing
   // the message.
   LongJump* base = isolate->long_jump_base();
   LongJump jump;
   isolate->set_long_jump_base(&jump);
-  *ErrorHandle() = LanguageError::New(
-      String::Handle(String::New("Error while writing message")));
   if (setjmp(*jump.Set()) == 0) {
     NoGCScope no_gc;
     WriteObject(obj.raw());
     UnmarkAll();
     isolate->set_long_jump_base(base);
   } else {
     isolate->set_long_jump_base(base);
     ThrowException(exception_type(), exception_msg());
   }
 }
 
 
 }  // namespace dart