DescriptionRevert of Let RenderFrameImpl set navigationStart based on CommonNavigationParams (patchset #2 id:20001 of https://codereview.chromium.org/1423453007/ )
Reason for revert:
Test fails on the bots:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/43015
RenderViewImplTest.NavigationStartOverride (run #1):
[ RUN ] RenderViewImplTest.NavigationStartOverride
[3788:2828:1105/152333:16934314:WARNING:resource_bundle.cc(305)] locale_file_path.empty() for locale
c:uild\slave\win_builder__dbg_uild\src\content\renderer\render_view_browsertest.cc(2282): error: Expected: (early_nav_reported_start) < (before_navigation), actual: 2015-11-05 23:23:33.730 UTC vs 2015-11-05 23:23:33.728 UTC
[ FAILED ] RenderViewImplTest.NavigationStartOverride (663 ms)
Original issue's description:
> Let RenderFrameImpl set navigationStart based on CommonNavigationParams
>
> This entails setting the timestamp before we set it in blink, so DocumentLoadTiming had to be modified to allow for that. We set the value in didCreateDataSource.
>
> didCreateDataSource was also refactored slightly so that same-page navigations don't need to call it anymore.
>
> This is 2/3 of the effort to add a navigation_start timestamp to DidStartProvisional load. The full CL we're breaking up is here:
> https://codereview.chromium.org/1425823002/
>
> BUG=548335
>
> Committed: https://crrev.com/5f61ecb107fd7118621a99fe03b094f37ce04394
> Cr-Commit-Position: refs/heads/master@{#358144}
TBR=jochen@chromium.org,clamy@chromium.org,csharrison@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=548335
Committed: https://crrev.com/ef4aafa5cad8305289dc041fd148158205e0a7df
Cr-Commit-Position: refs/heads/master@{#358192}
Patch Set 1 #
Messages
Total messages: 4 (0 generated)
|