<webview>: Focusing <webview> should propagate to BrowserPlugin.

chrome/renderer/resources/extensions/web_view.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Shim that simulates a <webview> tag via Mutation Observers.
 //
 // The actual tag is implemented via the browser plugin. The internals of this
 // are hidden via Shadow DOM.
 
 var chrome = requireNative('chrome').GetChrome();
@@ skipping 45 matching lines @@
   this.objectNode_.style.height = '100%';
   forEach(WEB_VIEW_ATTRIBUTES, function(i, attributeName) {
     // Only copy attributes that have been assigned values, rather than copying
     // a series of undefined attributes to BrowserPlugin.
     if (this.node_.hasAttribute(attributeName)) {
       this.objectNode_.setAttribute(
           attributeName, this.node_.getAttribute(attributeName));
     }
   }, this);
 
+  if (!this.node_.hasAttribute('tabIndex')) {
+    // <webview> needs a tabIndex in order to respond to keyboard focus.
+    // TODO(fsamuel): Maybe we should fix this so that it's not required.
+    this.node_.setAttribute('tabIndex', 0);

[lazyboy, 2013/04/15 21:46:58]

This feels too hacky though, and would trigger incorrect ordering of tab focus
iiuc.
I don't know focusing code enough, I think we should file a bug and fix this
properly soon.
Also, instead of setting the value explicitly to 0, would just adding the
attribute to this.node_ work? i.e. <webview tabIndex src="..."/>, that way at
least we can expect not to break tab ordering too much.

[Fady Samuel, 2013/04/15 22:15:28]

Unfortunately, that didn't work. I've added a bug to the comment that we should
fix this in Blink.

+  }
+  var self = this;
+  this.node_.addEventListener('focus', function(e) {
+    // Focus the BrowserPlugin when the <webview> takes focus.
+    self.objectNode_.focus();
+  });
+  this.node_.addEventListener('blur', function(e) {
+    // Blur the BrowserPlugin when the <webview> loses focus.
+    self.objectNode_.blur();
+  });
+
   shadowRoot.appendChild(this.objectNode_);
 
   // this.objectNode_[apiMethod] are not necessarily defined immediately after
   // the shadow object is appended to the shadow root.
-  var self = this;
   forEach(WEB_VIEW_API_METHODS, function(i, apiMethod) {
     node[apiMethod] = function(var_args) {
       return self.objectNode_[apiMethod].apply(self.objectNode_, arguments);
     };
   }, this);
 
   // Map attribute modifications on the <webview> tag to property changes in
   // the underlying <object> node.
   var handleMutation = function(i, mutation) {
     this.handleMutation_(mutation);
@@ skipping 118 matching lines @@
  */
 WebView.prototype.maybeSetupPermissionEvent_ = function() {};
 
 /**
  * Implemented when experimental permission is available.
  * @private
  */
 WebView.prototype.maybeSetupExecuteScript_ = function() {};
 
 exports.WebView = WebView;