Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1890)

Issue 1427183003: bin/sync-and-gyp: gclient hackery (Closed)

Created:
5 years, 1 month ago by hal.canary
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2015-10-30 (Friday) 18:04:29 EDT #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M bin/sync-and-gyp View 1 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
hal.canary
ptal
5 years, 1 month ago (2015-10-30 22:06:53 UTC) #2
mtklein
lgtm https://codereview.chromium.org/1427183003/diff/20001/bin/sync-and-gyp File bin/sync-and-gyp (right): https://codereview.chromium.org/1427183003/diff/20001/bin/sync-and-gyp#newcode28 bin/sync-and-gyp:28: printf ',s/"skia"/"."/\nwq\n' | ed .gclient Why not sed?
5 years, 1 month ago (2015-11-01 22:20:40 UTC) #3
hal.canary
On 2015/11/01 22:20:40, mtklein wrote: > lgtm > > https://codereview.chromium.org/1427183003/diff/20001/bin/sync-and-gyp > File bin/sync-and-gyp (right): > ...
5 years, 1 month ago (2015-11-02 18:11:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427183003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427183003/20001
5 years, 1 month ago (2015-11-02 18:11:41 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 18:22:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1f17364dc86de6f3e537440cd67cdb952b5e39f8

Powered by Google App Engine
This is Rietveld 408576698