Move MediaDrmBridge provision communication to native side.

content/browser/media/android/url_provision_fetcher.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_MEDIA_ANDROID_URL_PROVISION_FETCHER_H_

[xhwang, 2015/11/06 23:08:18]

tip: when moving file around, first upload a PS that only does the move, then
upload a PS with real changes. This way it's easy to see what has been updated
since last PS.

[Tima Vaisburd, 2015/11/11 03:03:34]

Acknowledged.

+#define CONTENT_BROWSER_MEDIA_ANDROID_URL_PROVISION_FETCHER_H_
+
+#include "base/macros.h"
+#include "media/base/provision_fetcher.h"
+#include "net/url_request/url_fetcher.h"
+#include "net/url_request/url_fetcher_delegate.h"
+
+namespace content {
+
+// The ProvisionFetcher that retrieves the data by HTTP POST request.
+
+class URLProvisionFetcher : public media::ProvisionFetcher,

[xhwang, 2015/11/06 23:08:18]

nit: All ProvisionFetch will use a URL, so it seems odd that this particular one
is a URLProvisionFetcher...

How about just something like ProvisionFetcherImpl?

[Tima Vaisburd, 2015/11/11 03:03:33]

I thought we will have another implementation for GPU process. Also, as defined
now, the ProvisionFetcher interface does not tell anything about URL or HTTP. I
meant, rather, direct HTTP call (versus GPU - Browser relay). We can change it
to ProvisionFetcherImpl, especially if there will be just one impl.

[xhwang, 2015/11/11 09:53:21]

Yes, I'll need one in the GPU process. That can be named something like
MojoProvisionFetcher, since it uses mojo services to do provisioning.

[Tima Vaisburd, 2015/11/11 23:26:35]

Shall we keep URLProvisionFetcher then? Or change to e.g.
BrowserProvisionFetcher to stress the process name?

[xhwang, 2015/11/12 22:27:03]

I really have no preference. Now "URL" seems okay too since we use a bunch of
URL* to implement it :)

[Tima Vaisburd, 2015/11/13 03:13:10]

kept current name.

+                            private net::URLFetcherDelegate {

[xhwang, 2015/11/06 23:08:18]

style: We don't use private inheritance.

https://google.github.io/styleguide/cppguide.html#Inheritance

[Tima Vaisburd, 2015/11/11 03:03:34]

Just changed to public, but, as the link says, I did mean impl. inheritance.
Would you prefer another member?

[xhwang, 2015/11/11 09:53:21]

There are 117 cases where net::URLFetcherDelegate is inherited publicly, so
public inheritance should be fine.

https://code.google.com/p/chromium/codesearch#search/&q=public%5C%20net::URLF...

[Tima Vaisburd, 2015/11/11 23:26:35]

Acknowledged.

+ public:
+  explicit URLProvisionFetcher(net::URLRequestContextGetter* context);
+  ~URLProvisionFetcher() override;
+
+  // media::ProvisionFetcher implementation.
+  void Retrieve(const std::string& default_url,
+                const std::string& request_data,
+                const media::ProvisionFetcher::ResponseCB& cb) override;

[xhwang, 2015/11/06 23:08:18]

nit: cb/response_cb/

[xhwang, 2015/11/06 23:08:18]

s/media::ProvisionFetcher::// since |this| is a media::ProvisionFetcher?

[Tima Vaisburd, 2015/11/11 23:26:35]

Done.

[Tima Vaisburd, 2015/11/11 23:26:35]

Done.

+
+ private:
+  // net::URLFetcherDelegate implementation.
+  void OnURLFetchComplete(const net::URLFetcher* source) override;
+
+  net::URLRequestContextGetter* url_request_context_;
+  scoped_ptr<net::URLFetcher> request_;
+  media::ProvisionFetcher::ResponseCB response_cb_;
+
+  DISALLOW_COPY_AND_ASSIGN(URLProvisionFetcher);
+};
+
+/*
+// A factory that creates URLProvisionFetcher objects.
+
+class URLProvisionFetcherFactory : public media::ProvisionFetcherFactory {
+ public:
+  scoped_ptr<media::ProvisionFetcher> CreateFetcher(
+      int render_process_id) const override;
+};
+*/

[xhwang, 2015/11/06 23:08:18]

remove

[Tima Vaisburd, 2015/11/11 03:03:33]

Done.

+}  // namespace content
+
+#endif  // CHROME_BROWSER_MEDIA_ANDROID_URL_PROVISION_FETCHER_H_