Chromium Code Reviews| Index: client/crashpad_client.h |
| diff --git a/client/crashpad_client.h b/client/crashpad_client.h |
| index d3d7e347ba5d4ecb345a936fd68fef45df5405cf..dc4a9481efe823c07b35bec67f6e4ca19ffa2b79 100644 |
| --- a/client/crashpad_client.h |
| +++ b/client/crashpad_client.h |
| @@ -72,13 +72,13 @@ class CrashpadClient { |
| const std::vector<std::string>& arguments); |
| #if defined(OS_WIN) || DOXYGEN |
| - //! \brief Sets the IPC port of a presumably-running Crashpad handler process |
| + //! \brief Sets the IPC pipe of a presumably-running Crashpad handler process |
| //! which was started with StartHandler() or by other compatible means |
| //! and does an IPC message exchange to register this process with the |
| //! handler. However, just like StartHandler(), crashes are not serviced |
| //! until UseHandler() is called. |
| //! |
| - //! The IPC port name (somehow) encodes enough information so that |
| + //! The IPC pipe name (somehow) encodes enough information so that |
|
scottmg
2015/11/02 22:15:40
This paragraph doesn't make sense any longer.
Mark Mentovai
2015/11/03 00:08:45
scottmg wrote:
|
| //! registration is done with a crash handler using the appropriate database |
| //! and upload server. |
| //! |
| @@ -88,6 +88,20 @@ class CrashpadClient { |
| //! \return `true` on success and `false` on failure. |
| bool SetHandlerIPCPipe(const std::wstring& ipc_pipe); |
| + //! \brief Retrieves the IPC pipe name used to register with the Crashpad |
| + //! handler. |
| + //! |
| + //! This method retrieves the IPC pipe name set by SetHandlerIPCPipe(), or a |
| + //! suitable IPC pipe name chosen by StartHandler(). It is intended to be used |
| + //! to obtain the IPC pipe name to pass it to other processes, so that they |
| + //! may register with an existing Crashpad handler. |
| + //! |
| + //! This method is only defined on Windows. |
| + //! |
| + //! \return The full name of the crash handler IPC pipe, a string of the form |
| + //! `"\\.\pipe\NAME"`. |
| + std::wstring GetHandlerIPCPipe() const; |
| + |
| //! \brief Requests that the handler capture a dump even though there hasn't |
| //! been a crash. |
| //! |