[Discardable Shared Memory] Adding Windows support.

base/memory/discardable_shared_memory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/discardable_shared_memory.h"
 
 #if defined(OS_POSIX) && !defined(OS_NACL)
 // For madvise() which is available on all POSIX compatible systems.
 #include <sys/mman.h>
 #endif
 
 #include <algorithm>
 
 #include "base/atomicops.h"
 #include "base/bits.h"
 #include "base/logging.h"
 #include "base/numerics/safe_math.h"
 #include "base/process/process_metrics.h"
 
 #if defined(OS_ANDROID)
 #include "third_party/ashmem/ashmem.h"
 #endif
 
+#if defined(OS_WIN)
+#include "base/win/windows_version.h"
+#endif
+
 namespace base {
 namespace {
 
 // Use a machine-sized pointer as atomic type. It will use the Atomic32 or
 // Atomic64 routines, depending on the architecture.
 typedef intptr_t AtomicType;
 typedef uintptr_t UAtomicType;
 
 // Template specialization for timestamp serialization/deserialization. This
 // is used to serialize timestamps using Unix time on systems where AtomicType
@@ skipping 57 matching lines @@
   return static_cast<SharedState*>(shared_memory.memory());
 }
 
 // Round up |size| to a multiple of page size.
 size_t AlignToPageSize(size_t size) {
   return bits::Align(size, base::GetPageSize());
 }
 
 }  // namespace
 
+// Indicates whether Lock/Unlock pinning is supported on this platform.
+// Call DoPinning() to access this information from within class functions.
+// static
+char DiscardableSharedMemory::pinning_supported_ = -1;
+
+// Lazy initialize pinning_supported_ to 0 (false) or 1 (true).
+// -1 when unchecked.
+bool DiscardableSharedMemory::DoPinning() {
+  bool supported = false;
+  switch (pinning_supported_) {
+    case 1:
+      supported = true;
+    case 0:
+      supported = false;
+    case -1:
+      pinning_supported_ = 0;
+#if defined(OS_ANDROID)
+      // Ashmem support.
+      pinning_supported_ = 1;
+      supported = true;
+#elif defined(OS_WIN)
+      // Check windows version.
+      // We need >= 8 for MEM_RESET_UNDO.
+      if (base::win::GetVersion() >= base::win::VERSION_WIN8) {

[reveman, 2015/11/03 00:23:57]

base::win::GetVersion() is cheap and already cached in a singleton so no need
for another level of caching here. Can we just move this check to the Lock()
function and remove this DoPinning function?

[penny, 2015/11/03 01:14:47]

Thank for this!  I missed the fact that OSInfo acts as a singleton and caches it
for me.  This is way cleaner now.

+        pinning_supported_ = 1;
+        supported = true;
+      }
+#endif
+  }
+  return supported;
+}
+
 DiscardableSharedMemory::DiscardableSharedMemory()
     : mapped_size_(0), locked_page_count_(0) {
 }
 
 DiscardableSharedMemory::DiscardableSharedMemory(
     SharedMemoryHandle shared_memory_handle)
     : shared_memory_(shared_memory_handle, false),
       mapped_size_(0),
       locked_page_count_(0) {
 }
@@ skipping 96 matching lines @@
   locked_page_count_ += end - start;
 #if DCHECK_IS_ON()
   // Detect incorrect usage by keeping track of exactly what pages are locked.
   for (auto page = start; page < end; ++page) {
     auto result = locked_pages_.insert(page);
     DCHECK(result.second);
   }
   DCHECK_EQ(locked_pages_.size(), locked_page_count_);
 #endif
 
+  if (DoPinning()) {

[reveman, 2015/11/03 00:23:57]

this check is never false on android so unnecessary in that case..

[penny, 2015/11/03 01:14:47]

Done.

 #if defined(OS_ANDROID)
-  SharedMemoryHandle handle = shared_memory_.handle();
-  if (SharedMemory::IsHandleValid(handle)) {
-    if (ashmem_pin_region(
-            handle.fd, AlignToPageSize(sizeof(SharedState)) + offset, length)) {
+    SharedMemoryHandle handle = shared_memory_.handle();
+    if (SharedMemory::IsHandleValid(handle)) {
+      if (ashmem_pin_region(
+        handle.fd, AlignToPageSize(sizeof(SharedState)) + offset, length)) {
+        return PURGED;
+      }
+    }
+#elif defined(OS_WIN)
+    if (nullptr == VirtualAlloc(reinterpret_cast<char*>(

[reveman, 2015/11/03 00:23:57]

nit: chromium style is "if (!VirtualAlloc(reinte..."

[penny, 2015/11/03 01:14:47]

Done.

+                                    shared_memory_.memory()) +
+                                    AlignToPageSize(
+                                        sizeof(SharedState)) +
+                                    offset,
+                                length,
+                                MEM_RESET_UNDO,
+                                PAGE_READWRITE)) {
       return PURGED;
     }
+#endif
   }
-#endif
 
   return SUCCESS;
 }
 
 void DiscardableSharedMemory::Unlock(size_t offset, size_t length) {
   DCHECK_EQ(AlignToPageSize(offset), offset);
   DCHECK_EQ(AlignToPageSize(length), length);
 
   // Calls to this function must be synchronized properly.
   DFAKE_SCOPED_LOCK(thread_collision_warner_);
 
   // Zero for length means "everything onward".
   if (!length)
     length = AlignToPageSize(mapped_size_) - offset;
 
   DCHECK(shared_memory_.memory());
 
+  if (DoPinning()) {
 #if defined(OS_ANDROID)
-  SharedMemoryHandle handle = shared_memory_.handle();
-  if (SharedMemory::IsHandleValid(handle)) {
-    if (ashmem_unpin_region(
-            handle.fd, AlignToPageSize(sizeof(SharedState)) + offset, length)) {
-      DPLOG(ERROR) << "ashmem_unpin_region() failed";
+    SharedMemoryHandle handle = shared_memory_.handle();
+    if (SharedMemory::IsHandleValid(handle)) {
+      if (ashmem_unpin_region(
+        handle.fd, AlignToPageSize(sizeof(SharedState)) + offset, length)) {
+        DPLOG(ERROR) << "ashmem_unpin_region() failed";
+      }
     }
+#elif defined(OS_WIN)
+    if (nullptr == VirtualAlloc(reinterpret_cast<char*>(

[reveman, 2015/11/03 00:23:57]

if (!VirtualAlloc(reinte...

[penny, 2015/11/03 01:14:47]

Done.

+                                    shared_memory_.memory()) +
+                                    AlignToPageSize(
+                                        sizeof(SharedState)) +
+                                    offset,
+                                length,
+                                MEM_RESET,
+                                PAGE_READWRITE)) {
+        DPLOG(ERROR) << "VirtualAlloc() MEM_RESET failed in Unlock()";
+      }
+#endif
   }
-#endif
 
   size_t start = offset / base::GetPageSize();
   size_t end = start + length / base::GetPageSize();
   DCHECK_LT(start, end);
   DCHECK_LE(end, AlignToPageSize(mapped_size_) / base::GetPageSize());
 
   // Remove pages from |locked_page_count_|.
   // Note: Unlocking a page that is not locked is an error.
   DCHECK_GE(locked_page_count_, end - start);
   locked_page_count_ -= end - start;
@@ skipping 71 matching lines @@
 #define MADV_PURGE_ARGUMENT MADV_FREE
 #endif
   // Advise the kernel to remove resources associated with purged pages.
   // Subsequent accesses of memory pages will succeed, but might result in
   // zero-fill-on-demand pages.
   if (madvise(reinterpret_cast<char*>(shared_memory_.memory()) +
                   AlignToPageSize(sizeof(SharedState)),
               AlignToPageSize(mapped_size_), MADV_PURGE_ARGUMENT)) {
     DPLOG(ERROR) << "madvise() failed";
   }
+#elif defined(OS_WIN)
+  // MEM_DECOMMIT the purged pages to release the physical storage,
+  // either in memory or in the paging file on disk.  Pages remain RESERVED.
+  // NOTE: this is the best that can be done from the browser, until the
+  // child/renderer notices the purge and releases its own handles.
+  if (!VirtualFree(reinterpret_cast<char*>(shared_memory_.memory()) +
+                      AlignToPageSize(sizeof(SharedState)),
+                   AlignToPageSize(mapped_size_),
+                   MEM_DECOMMIT)) {
+    DPLOG(ERROR) << "VirtualFree() MEM_DECOMMIT failed in Purge()";
+  }
 #endif
 
   last_known_usage_ = Time();
   return true;
 }
 
 bool DiscardableSharedMemory::IsMemoryResident() const {
   DCHECK(shared_memory_.memory());
 
   SharedState result(subtle::NoBarrier_Load(
@@ skipping 14 matching lines @@
 
 void DiscardableSharedMemory::Close() {
   shared_memory_.Close();
 }
 
 Time DiscardableSharedMemory::Now() const {
   return Time::Now();
 }
 
 }  // namespace base