[Interpreter] Don't compile Api or Builtin id functions through the interpreter.

[Interpreter] Don't compile Api or Builtin id functions through the interpreter.

The Interpreter uses the function_data slot in the shared function info, so
can't be used to compile functions which use that field for other reasons,
such as API functions or functions with builtin function ids.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/e4b4dd41eda4742f1cc4664f590d6459270e1526
Cr-Commit-Position: refs/heads/master@{#31721}

[rmcilroy, 2015-10-30 17:14:47]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[rmcilroy, 2015-10-30 17:14:48]

Michi, could you take a look please. This is part of an effort to enable us to
run without the --ignition-script-filter flag.

[rmcilroy, 2015-10-30 17:14:54]

Michi, could you take a look please. This is part of an effort to enable us to
run without the --ignition-script-filter flag.

[rmcilroy, 2015-10-30 17:16:44]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-30 17:16:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1427143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1427143002/1

[commit-bot: I haz the power, 2015-10-30 17:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-30 17:38:07]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2015-11-02 14:08:43]

https://codereview.chromium.org/1427143002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1427143002/diff/1/src/compiler.cc#newcode751
src/compiler.cc:751: !shared->IsApiFunction() && !shared->HasBuiltinFunctionId()
&&
Can SharedFunctionInfo::IsApiFunction() really happen here? This would really
surprise/concern me, because those function should never get anything resembling
a lazy-compile stub installed. I would vote for dropping that part of the
predicate.

[rmcilroy, 2015-11-02 17:55:38]

https://codereview.chromium.org/1427143002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1427143002/diff/1/src/compiler.cc#newcode751
src/compiler.cc:751: !shared->IsApiFunction() && !shared->HasBuiltinFunctionId()
&&
On 2015/11/02 14:08:43, Michael Starzinger wrote:
> Can SharedFunctionInfo::IsApiFunction() really happen here? This would really
> surprise/concern me, because those function should never get anything
resembling
> a lazy-compile stub installed. I would vote for dropping that part of the
> predicate.

Yeah, this doesn't seem to happen, at least in the code I'm running. Dropped the
IsApiFunction() part.

[Michael Starzinger, 2015-11-02 19:52:00]

LGTM.

[rmcilroy, 2015-11-02 20:11:21]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-11-02 20:11:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1427143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1427143002/20001

[commit-bot: I haz the power, 2015-11-02 20:37:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-02 20:38:30]

Patchset 2 (id:??) landed as
https://crrev.com/e4b4dd41eda4742f1cc4664f590d6459270e1526
Cr-Commit-Position: refs/heads/master@{#31721}