Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issue 142713006: Remove LASTCHANGE dependency (Closed)

Created:
6 years, 10 months ago by Sergey Ulanov
Modified:
6 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Remove LASTCHANGE dependency from remoting host on windows Remoting host on windows contains latest revision number so parts of remoting are rebuilt every time revision number changes. Removed dependency on LASTCHANGE to prevent ninja from rebuilding remoting every time. The file is still used. BUG=332679 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247864

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M remoting/remoting_host_win.gypi View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
6 years, 10 months ago (2014-01-29 23:32:18 UTC) #1
Jamie
lgtm https://codereview.chromium.org/142713006/diff/1/remoting/remoting_host_win.gypi File remoting/remoting_host_win.gypi (left): https://codereview.chromium.org/142713006/diff/1/remoting/remoting_host_win.gypi#oldcode392 remoting/remoting_host_win.gypi:392: '<(lastchange_path)', Can you add a comment explaining why ...
6 years, 10 months ago (2014-01-29 23:43:26 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/142713006/diff/1/remoting/remoting_host_win.gypi File remoting/remoting_host_win.gypi (left): https://codereview.chromium.org/142713006/diff/1/remoting/remoting_host_win.gypi#oldcode392 remoting/remoting_host_win.gypi:392: '<(lastchange_path)', On 2014/01/29 23:43:26, Jamie wrote: > Can you ...
6 years, 10 months ago (2014-01-29 23:50:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/142713006/30001
6 years, 10 months ago (2014-01-29 23:55:33 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 07:09:53 UTC) #5
Message was sent while issue was closed.
Change committed as 247864

Powered by Google App Engine
This is Rietveld 408576698