Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1779)

Issue 14271007: Remove public bool ChangeListLoader::loaded(). (Closed)

Created:
7 years, 8 months ago by kinaba
Modified:
7 years, 8 months ago
Reviewers:
hashimoto, satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove public bool ChangeListLoader::loaded(). Now, the only outside caller of the method is drive-internals. However, after we have moved to DB store, loaded is equivalent to having changestamp > 0. So there's no need to have both in the UI. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194783

Patch Set 1 #

Total comments: 2

Patch Set 2 : (loaded) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M chrome/browser/chromeos/drive/change_list_loader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_metadata.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_metadata.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/drive_internals.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/drive_internals.js View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
7 years, 8 months ago (2013-04-18 03:42:57 UTC) #1
satorux1
LGTM https://codereview.chromium.org/14271007/diff/1/chrome/browser/resources/chromeos/drive_internals.html File chrome/browser/resources/chromeos/drive_internals.html (right): https://codereview.chromium.org/14271007/diff/1/chrome/browser/resources/chromeos/drive_internals.html#newcode61 chrome/browser/resources/chromeos/drive_internals.html:61: <span id='account-largest-changestamp-local'></span> You might want to add something ...
7 years, 8 months ago (2013-04-18 03:50:59 UTC) #2
hashimoto
lgtm
7 years, 8 months ago (2013-04-18 04:03:05 UTC) #3
kinaba
https://codereview.chromium.org/14271007/diff/1/chrome/browser/resources/chromeos/drive_internals.html File chrome/browser/resources/chromeos/drive_internals.html (right): https://codereview.chromium.org/14271007/diff/1/chrome/browser/resources/chromeos/drive_internals.html#newcode61 chrome/browser/resources/chromeos/drive_internals.html:61: <span id='account-largest-changestamp-local'></span> On 2013/04/18 03:50:59, satorux1 wrote: > You ...
7 years, 8 months ago (2013-04-18 05:31:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/14271007/8001
7 years, 8 months ago (2013-04-18 05:32:09 UTC) #5
kinaba
7 years, 8 months ago (2013-04-18 05:35:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r194783 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698