Issue 1427033004: Revert of [Telemetry] Enable screenshot taking on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1427033004: Revert of [Telemetry] Enable screenshot taking on Mac (Closed)

Created:
5 years, 1 month ago by dgozman

Modified:
5 years, 1 month ago

Reviewers:
eakuefner, nednguyen

CC:
chromium-reviews, telemetry-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of [Telemetry] Enable screenshot taking on Mac (patchset #2 id:20001 of https://codereview.chromium.org/1415133005/ ) Reason for revert: Broke telemetry_unittests on Mac: https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/8449 Original issue's description: > [Telemetry] Enable screenshot taking on Mac > > BUG=369490 > > Committed: https://crrev.com/e887c296c741e723e6787ad4b684b65d3a59729d > Cr-Commit-Position: refs/heads/master@{#356951} TBR=eakuefner@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369490 Committed: https://crrev.com/d492ca45e24095a4614476a8ffe62b6ac5ad3fb8 Cr-Commit-Position: refs/heads/master@{#356980}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -63 lines)			Patch
D	tools/telemetry/telemetry/core/platform_unittest.py	View	1 chunk	+0 lines, -37 lines	0 comments	Download
M	tools/telemetry/telemetry/internal/platform/mac_platform_backend.py	View	2 chunks	+0 lines, -7 lines	0 comments	Download
D	tools/telemetry/telemetry/internal/testing/screenshot_test.html	View	1 chunk	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dgozman

Created Revert of [Telemetry] Enable screenshot taking on Mac

5 years, 1 month ago (2015-10-29 23:27:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427033004/1

5 years, 1 month ago (2015-10-29 23:27:36 UTC) #2

commit-bot: I haz the power

5 years, 1 month ago (2015-10-29 23:30:13 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d492ca45e24095a4614476a8ffe62b6ac5ad3fb8
Cr-Commit-Position: refs/heads/master@{#356980}

Expand Messages | Collapse Messages