Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 142703011: Revert "Retry "Replace RenderFullScreen with top layer"" (Closed)

Created:
6 years, 10 months ago by falken
Modified:
6 years, 10 months ago
Reviewers:
hidehiko, esprehn
CC:
blink-reviews, zoltan1, dsinclair, sof, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, blink-layers+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, Inactive, mazda
Visibility:
Public.

Description

Revert "Retry "Replace RenderFullScreen with top layer"" This reverts commit 9877946002a47509b8f737b756d5589812ec375c. Revert "Auto-rebaseline for r166304" This reverts commit ff6adb9065a035cb3604f067021da882544e5a93. Revert "Mark full-screen-video-has-backdrop.html as flaky." This reverts commit 850bb332da7a9bbdba68d91ecd9e1cf68abea612. The change apparently breaks setAttribute behavior for plugins, though there is not an easy repro test case yet. BUG=240576, 246077 TBR=hidehiko,esprehn NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -301 lines) Patch
M LayoutTests/TestExpectations View 4 chunks +5 lines, -7 lines 0 comments Download
D LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality.html View 1 chunk +0 lines, -105 lines 0 comments Download
D LayoutTests/fast/dom/HTMLDialogElement/fullscreen-elements-do-not-affect-modality-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/fullscreen/anonymous-block-merge-crash.html View 1 chunk +3 lines, -9 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-is-in-top-layer.html View 1 chunk +0 lines, -40 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-placeholder.html View 1 chunk +73 lines, -0 lines 0 comments Download
A LayoutTests/fullscreen/full-screen-placeholder-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
D LayoutTests/fullscreen/full-screen-video-has-backdrop.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/platform/android/virtual/android/fullscreen/full-screen-video-has-backdrop-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/linux-x86/virtual/android/fullscreen/full-screen-video-has-backdrop-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/linux/fullscreen/parent-flow-inline-with-block-child-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/virtual/android/fullscreen/full-screen-video-has-backdrop-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fullscreen/full-screen-video-has-backdrop-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/fullscreen/full-screen-video-has-backdrop-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-retina/fullscreen/full-screen-video-has-backdrop-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/mac-snowleopard/fullscreen/full-screen-video-has-backdrop-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win/fullscreen/full-screen-placeholder-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/fullscreen.css View 1 chunk +1 line, -22 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.h View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 10 chunks +50 lines, -14 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDialogElement.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 4 chunks +0 lines, -10 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 3 chunks +1 line, -16 lines 0 comments Download
A + Source/core/rendering/RenderFullScreen.h View 2 chunks +23 lines, -19 lines 0 comments Download
A Source/core/rendering/RenderFullScreen.cpp View 1 chunk +189 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderInline.cpp View 2 chunks +12 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderVideo.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
falken
6 years, 10 months ago (2014-02-04 12:52:41 UTC) #1
hidehiko
[+cc: mazda] looks good (though, I'm not familiar with this code). Thank you for your ...
6 years, 10 months ago (2014-02-04 13:02:10 UTC) #2
falken
The CQ bit was checked by falken@chromium.org
6 years, 10 months ago (2014-02-04 13:06:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/142703011/1
6 years, 10 months ago (2014-02-04 13:06:49 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 13:07:47 UTC) #5
Message was sent while issue was closed. 
Change committed as 166394

Powered by Google App Engine
This is Rietveld 408576698