Issue 142703003: Make PopupMenuTest run on all platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 142703003: Make PopupMenuTest run on all platforms. (Closed)

Created:
6 years, 11 months ago by dglazkov

Modified:
6 years, 11 months ago

Reviewers:
Kunihiko Sakamoto, eae

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Make PopupMenuTest run on all platforms. This is not as much of a porting effort as just straightening out the sheetmetal. Technically, the change removes vestigal (from back at http://trac.webkit.org/changeset/14337) shortcut of initializing Font straight out of FontPlatformData, which we don't use. But hey, better testing as a result? Can't complain. R=eae,ksakamoto@chromium.org BUG=319475 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165415

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -26 lines)			Patch
M	Source/platform/fonts/Font.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/platform/fonts/Font.cpp	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	Source/platform/fonts/FontFallbackList.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/platform/fonts/FontFallbackList.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/web/tests/PopupMenuTest.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	Source/web/web.gypi	View	2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/142703003/1

6 years, 11 months ago (2014-01-20 15:24:46 UTC) #3

Message was sent while issue was closed.

Change committed as 165415