Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1427023004: Add UDIV to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove tabs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -18 lines) Patch
M src/DartARM32/assembler_arm.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
A + tests_lit/assembler/arm32/udiv.ll View 1 3 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Karl
5 years, 1 month ago (2015-10-30 20:51:29 UTC) #3
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-10-30 21:44:01 UTC) #4
Karl
5 years, 1 month ago (2015-10-30 22:00:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1c28550f76d2da45def3b4bf43732c8d30b8c9f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698