Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Issue 1427003006: Enable ARMv8 32-bit build. (Closed)

Created:
5 years, 1 month ago by baptiste.afsa1
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable ARMv8 32-bit build. R=danno@chromium.org Committed: https://crrev.com/ec612537869656c427b8a000568cd163dc995a0b Cr-Commit-Position: refs/heads/master@{#31690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M src/arm/assembler-arm.cc View 4 chunks +22 lines, -3 lines 0 comments Download
M src/base/build_config.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +9 lines, -1 line 0 comments Download
M test/mjsunit/math-floor-of-div-nosudiv.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
baptiste.afsa1
PTAL
5 years, 1 month ago (2015-10-30 11:12:47 UTC) #1
danno
Hi Babtiste! Looking pretty good. Does it make sense to integrate this patch into yours ...
5 years, 1 month ago (2015-10-30 12:31:24 UTC) #3
danno
lgtm
5 years, 1 month ago (2015-10-30 13:22:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427003006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427003006/1
5 years, 1 month ago (2015-10-30 13:22:51 UTC) #6
Michael Achenbach
FYI: I triggered the new trybot v8_linux_arm_armv8a_rel for this.
5 years, 1 month ago (2015-10-30 13:51:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 14:10:29 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 14:11:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec612537869656c427b8a000568cd163dc995a0b
Cr-Commit-Position: refs/heads/master@{#31690}

Powered by Google App Engine
This is Rietveld 408576698