Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1427003003: [ios] Removed DCHECK which prevents WKProcessPool manual creation. (Closed)

Created:
5 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
5 years, 1 month ago
Reviewers:
shreyasv1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed DCHECK which prevents WKProcessPool manual creation. That DCHECK was originally added to: 1.) Prevent issues with WKWebView cookie clearing on iOS8 (not supported by WKWebView anymore). 2.) Ensure correct Modal Data Partitioning (postponed work). BUG=537244 Committed: https://crrev.com/2de015203b33dfb0c040b0eaa4ce4c8fb52ade8a Cr-Commit-Position: refs/heads/master@{#357123}

Patch Set 1 #

Patch Set 2 : Added back required include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -79 lines) Patch
M ios/web/web_state/ui/wk_web_view_configuration_provider.mm View 1 2 chunks +0 lines, -79 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Eugene But (OOO till 7-30)
5 years, 1 month ago (2015-10-29 16:02:33 UTC) #2
shreyasv1
s/WKWebsiteDataStore/WKProcessPool in the description. LGTM with the change in
5 years, 1 month ago (2015-10-30 15:26:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427003003/1
5 years, 1 month ago (2015-10-30 15:41:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/88197)
5 years, 1 month ago (2015-10-30 15:50:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1427003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1427003003/20001
5 years, 1 month ago (2015-10-30 16:33:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 16:47:08 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 16:47:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2de015203b33dfb0c040b0eaa4ce4c8fb52ade8a
Cr-Commit-Position: refs/heads/master@{#357123}

Powered by Google App Engine
This is Rietveld 408576698