Identity API: getAuthToken request queues (token cache prelude)

Identity API: getAuthToken request queues (token cache prelude)

Serializing calls to getAuthToken will eliminate unnecessary calls to
GAIA and consolidate UI flows.

There is are two queues of requests for each (extension, scopes)
tuple, one for the non-interactive IssueToken flow and one for the
interactive prompt.

BUG=228908
(step #1 of the bug description)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194627

[Michael Courage, 2013-04-15 23:45:22]

Hi James & Nico, please review.

koz: chrome/browser/extensions/api/identity/*
thakis: chrome/browser/*.gypi

[koz (OOO until 15th September), 2013-04-16 06:22:32]

Sorry, but I don't think I'm a good reviewer for this as I'm unfamiliar with the
identity API.

Mike, could you suggest an appropriate reviewer?

[Michael Courage, 2013-04-16 14:40:20]

+miket to reviewers for email To: line

[miket_OOO, 2013-04-16 15:27:52]

> Mike, could you suggest an appropriate reviewer?

I suggest myself. Got it.

[miket_OOO, 2013-04-16 20:42:56]

lgtm

https://codereview.chromium.org/14270007/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/identity/identity_api.h (right):

https://codereview.chromium.org/14270007/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/identity/identity_api.h:78: void
CompleteFunctionWithResult(const std::string& access_token);
Should these two have OVERRIDE? If not, they don't belong under this header.

[Michael Courage, 2013-04-16 22:04:23]

https://codereview.chromium.org/14270007/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/identity/identity_api.h (right):

https://codereview.chromium.org/14270007/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/identity/identity_api.h:78: void
CompleteFunctionWithResult(const std::string& access_token);
On 2013/04/16 20:42:56, miket wrote:
> Should these two have OVERRIDE? If not, they don't belong under this header.

Done.

[Nico, 2013-04-16 22:15:18]

gypi lgtm

[Dmitry Titov, 2013-04-17 17:49:30]

Committed patchset #2 manually as r194627 (presubmit successful).