Omnibox: Add UMA Histogram to Dashboard

Omnibox: Add UMA Histogram to Dashboard

Adds new histogram to histograms.xml

This histogram was added in
https://codereview.chromium.org/13730016/

BUG=219218
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194363

[Mark P, 2013-04-15 22:08:34]

This is much easier than using the internal repository.

--mark

[Ilya Sherman, 2013-04-16 01:11:55]

LGTM.

As a follow-up, any chance you'd be willing to take on the task of open-sourcing
(most of) the other omnibox histograms?

https://codereview.chromium.org/14270005/diff/2001/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/14270005/diff/2001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:4678: <int value="0" label="entered
keymode mode via tab"/>
nit: I'd recommend dropping the common "entered keyword mode " prefix, or at
least shortening it "entered".  But if you keep the current wording, "keymode"
-> "keyword"

[Mark P, 2013-04-16 15:04:14]

> As a follow-up, any chance you'd be willing to take on the task of
> open-sourcing (most of) the other omnibox histograms?

Okay,

--mark

https://codereview.chromium.org/14270005/diff/2001/tools/metrics/histograms/h...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/14270005/diff/2001/tools/metrics/histograms/h...
tools/metrics/histograms/histograms.xml:4678: <int value="0" label="entered
keymode mode via tab"/>
On 2013/04/16 01:11:55, Ilya Sherman wrote:
> nit: I'd recommend dropping the common "entered keyword mode " prefix, or at
> least shortening it "entered".

Done.

> But if you keep the current wording, "keymode"
> -> "keyword"

[Mark P, 2013-04-16 15:05:29]

Committed patchset #3 manually as r194363 (presubmit successful).