Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2605)

Unified Diff: ui/ozone/common/gpu/ozone_gpu_message_params.h

Issue 1426993003: Ozone: Dont hardcode format to YUV when using Overlay Composition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cosmetic fixes Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/common/gpu/ozone_gpu_message_params.h
diff --git a/ui/ozone/common/gpu/ozone_gpu_message_params.h b/ui/ozone/common/gpu/ozone_gpu_message_params.h
index ae9e83f41311fe7f50a981286c949e8ee3f741df..abca62941c9809be15561fa1fbfe6d4956850c9c 100644
--- a/ui/ozone/common/gpu/ozone_gpu_message_params.h
+++ b/ui/ozone/common/gpu/ozone_gpu_message_params.h
@@ -48,9 +48,12 @@ struct OZONE_EXPORT DisplaySnapshot_Params {
};
struct OZONE_EXPORT OverlayCheck_Params {
+ enum State { kTest, kInvalid, kCompatible, kOverlay };
dnicoara 2015/11/23 19:22:54 nit: Could you please have kInvalid as the first s
+
OverlayCheck_Params();
OverlayCheck_Params(
const OverlayCandidatesOzone::OverlaySurfaceCandidate& candidate);
+ bool operator==(const OverlayCheck_Params& param) const;
~OverlayCheck_Params();
gfx::Size buffer_size;
@@ -62,9 +65,28 @@ struct OZONE_EXPORT OverlayCheck_Params {
// Higher the value, the more important it is to ensure that this
// overlay candidate finds a compatible free hardware plane to use.
uint32_t weight;
- // Will be set in GPU process. These are unique plane ids of primary display
- // supporting this configuration.
- std::vector<uint32_t> plane_ids;
+ // state can contain the following values:
+ // kTest : This is a new configuration which needs to be tested. Usually
+ // this state is set when OverlayCheck_Params is created by
+ // taking OverlaySurfaceCandidate in its constructor.
+ // kInvalid : This configuration has been tested and has proven to be
+ // incompatible with the current setup.
+ // kCompatible: This configuration has been tested and we have hardware planes
+ // which can support this configuration. This doesn't mean that
+ // the overlay candidate should be promoted to use hardware
+ // planes. This depends on the weight of this candidate,
+ // available hardware resources and total no of overlay
+ // candidates.
+ // kOverlay : This configuration is compatible with the current setup and
+ // overlay candidate should be promoted to use Hardware Overlay.
+ State state;
+ // The following params are set to appropriate values by DrmOverlayCandidate
+ // after checking and validating the optimal configuration.
+
+ // This is optimal storage format for the buffer.
+ gfx::BufferFormat optimal_format;
+ // This is the required buffer size.
+ gfx::Size required_buffer_size;
};
} // namespace ui
« no previous file with comments | « no previous file | ui/ozone/common/gpu/ozone_gpu_message_params.cc » ('j') | ui/ozone/platform/drm/gpu/drm_overlay_candidate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698