Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1426943011: MD Settings: Adding Powerwash dialog for ChromeOS. (Closed)

Created:
5 years, 1 month ago by dpapad
Modified:
5 years, 1 month ago
Reviewers:
stevenjb
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@reset_ui2_separate_element
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Adding Powerwash dialog for ChromeOS. The dialog is not styled at all yet, while waiting for mocks. C++ handlers will be migrated in follow up CL. BUG=546840 Committed: https://crrev.com/31f285abcb50674f12237c1638f86a49c38009ea Cr-Commit-Position: refs/heads/master@{#359193}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Total comments: 4

Patch Set 4 : Address comments. #

Patch Set 5 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -3 lines) Patch
A chrome/browser/resources/settings/reset_page/powerwash_dialog.html View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/reset_page/powerwash_dialog.js View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_page.html View 1 chunk +11 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_page.js View 1 chunk +17 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
dpapad
FYI this CL is based on top of https://codereview.chromium.org/1419053008 which is LGed and should land ...
5 years, 1 month ago (2015-11-10 23:10:25 UTC) #2
stevenjb
https://codereview.chromium.org/1426943011/diff/40001/chrome/browser/resources/settings/reset_page/powerwash_dialog.html File chrome/browser/resources/settings/reset_page/powerwash_dialog.html (right): https://codereview.chromium.org/1426943011/diff/40001/chrome/browser/resources/settings/reset_page/powerwash_dialog.html#newcode10 chrome/browser/resources/settings/reset_page/powerwash_dialog.html:10: <div> div not needed https://codereview.chromium.org/1426943011/diff/40001/chrome/browser/resources/settings/reset_page/powerwash_dialog.html#newcode15 chrome/browser/resources/settings/reset_page/powerwash_dialog.html:15: >Learn more</paper-button> i18n
5 years, 1 month ago (2015-11-11 20:21:19 UTC) #3
dpapad
https://codereview.chromium.org/1426943011/diff/40001/chrome/browser/resources/settings/reset_page/powerwash_dialog.html File chrome/browser/resources/settings/reset_page/powerwash_dialog.html (right): https://codereview.chromium.org/1426943011/diff/40001/chrome/browser/resources/settings/reset_page/powerwash_dialog.html#newcode10 chrome/browser/resources/settings/reset_page/powerwash_dialog.html:10: <div> On 2015/11/11 at 20:21:19, stevenjb wrote: > div ...
5 years, 1 month ago (2015-11-11 21:22:34 UTC) #4
stevenjb
lgtm
5 years, 1 month ago (2015-11-11 22:09:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426943011/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426943011/60001
5 years, 1 month ago (2015-11-11 22:16:49 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 1 month ago (2015-11-11 22:16:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1426943011/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1426943011/100001
5 years, 1 month ago (2015-11-11 22:44:06 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 1 month ago (2015-11-12 00:22:20 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:02:05 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/31f285abcb50674f12237c1638f86a49c38009ea
Cr-Commit-Position: refs/heads/master@{#359193}

Powered by Google App Engine
This is Rietveld 408576698