Refactor Windows DPI Point, Rect, and Size for Multiple Monitor DPI Awareness

ui/gfx/display.h

Index: ui/gfx/display.h
diff --git a/ui/gfx/display.h b/ui/gfx/display.h
index c6df7e703ad54dba04977ee2ce6ed1a6d9df791a..c067b3e3b913100712207c6c033e999d610de258 100644
--- a/ui/gfx/display.h
+++ b/ui/gfx/display.h
@@ -58,7 +58,7 @@ class GFX_EXPORT Display {
   Display();
   explicit Display(int64_t id);
   Display(int64_t id, const Rect& bounds);
-  ~Display();
+  virtual ~Display();

[oshima, 2016/01/15 18:26:03]

Did you add subclass? I haven't look at other changes, but gfx::Display is
copyable by design, so it shouldn't have subclasses.

[robliao, 2016/01/15 19:28:16]

Yes, but it doesn't preclude copying. ScreenWin::DisplayWin maintains the
untransformed screen pixel bounds. I figured all outside uses of Display were
outbound of the Screen, so DisplayWin is fully contained within ScreenWin. When
a gfx::Display needs to be handed out, a DisplayWin is always copied to a
gfx::Display.

[oshima, 2016/01/15 19:55:53]

Style guide recommends to avoid it, and even if it works now, I still want to
avoid it because it's error prone.
Looks like you just want to remember physical bounds inside ScreenWin. Can you
just keep the mapping inside it?

 
   // Returns the forced device scale factor, which is given by
   // "--force-device-scale-factor".