chrome/browser/ui/views/tabs/tab_strip.cc - Issue 1426933002: Refactor Windows DPI Point, Rect, and Size for Multiple Monitor DPI Awareness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 1426933002: Refactor Windows DPI Point, Rect, and Size for Multiple Monitor DPI Awareness (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR Feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc ('K') | « chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc ('k') | chrome/browser/ui/views/tabs/window_finder_win.cc » ('j') | ui/gfx/screen_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_strip.cc

diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc

index 5269e9947f96702fd54e6fc6d967b17fed866020..b6d12a55826257c0c569b059e622d355fd2c8cba 100644

--- a/chrome/browser/ui/views/tabs/tab_strip.cc

+++ b/chrome/browser/ui/views/tabs/tab_strip.cc

@@ -61,7 +61,7 @@

#include "ui/views/window/non_client_view.h"

#if defined(OS_WIN)

-#include "ui/gfx/win/dpi.h"

+#include "ui/gfx/screen_win.h"

#include "ui/gfx/win/hwnd_util.h"

#include "ui/views/widget/monitor_win.h"

#include "ui/views/win/hwnd_util.h"

@@ -311,7 +311,7 @@ void NewTabButton::OnMouseReleased(const ui::MouseEvent& event) {

if (event.IsOnlyRightMouseButton()) {

gfx::Point point = event.location();

views::View::ConvertPointToScreen(this, &point);

- point = gfx::win::DIPToScreenPoint(point);

+ point = gfx::ScreenWin::DIPToScreenPoint(point);

bool destroyed = false;

destroyed_ = &destroyed;

gfx::ShowSystemMenuAtPoint(views::HWNDForView(this), point);